diff options
author | Josh Matthews <josh@joshmatthews.net> | 2024-08-22 07:42:36 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-08-22 11:42:36 +0000 |
commit | 60ef6bc46125d34e492a4294622e2791f3c619b5 (patch) | |
tree | 8bc8a90f3a4647a7d6565065a8d73bd1b8f29d3d /components/script/dom/xrrigidtransform.rs | |
parent | 9a1051c9170abc8e40c43b2a6be712a3ff4b523f (diff) | |
download | servo-60ef6bc46125d34e492a4294622e2791f3c619b5.tar.gz servo-60ef6bc46125d34e492a4294622e2791f3c619b5.zip |
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Propagate CanGc from reflect_dom_object_with_proto.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Mark DOM constructors as GC operations.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/xrrigidtransform.rs')
-rw-r--r-- | components/script/dom/xrrigidtransform.rs | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/components/script/dom/xrrigidtransform.rs b/components/script/dom/xrrigidtransform.rs index 2f44b23b44e..a90121ee424 100644 --- a/components/script/dom/xrrigidtransform.rs +++ b/components/script/dom/xrrigidtransform.rs @@ -17,7 +17,7 @@ use crate::dom::dompointreadonly::DOMPointReadOnly; use crate::dom::globalscope::GlobalScope; use crate::dom::window::Window; use crate::dom::xrsession::ApiRigidTransform; -use crate::script_runtime::JSContext; +use crate::script_runtime::{CanGc, JSContext}; #[dom_struct] pub struct XRRigidTransform { @@ -45,18 +45,20 @@ impl XRRigidTransform { } pub fn new(global: &GlobalScope, transform: ApiRigidTransform) -> DomRoot<XRRigidTransform> { - Self::new_with_proto(global, None, transform) + Self::new_with_proto(global, None, transform, CanGc::note()) } fn new_with_proto( global: &GlobalScope, proto: Option<HandleObject>, transform: ApiRigidTransform, + can_gc: CanGc, ) -> DomRoot<XRRigidTransform> { reflect_dom_object_with_proto( Box::new(XRRigidTransform::new_inherited(transform)), global, proto, + can_gc, ) } @@ -70,6 +72,7 @@ impl XRRigidTransform { pub fn Constructor( window: &Window, proto: Option<HandleObject>, + can_gc: CanGc, position: &DOMPointInit, orientation: &DOMPointInit, ) -> Fallible<DomRoot<Self>> { @@ -98,6 +101,7 @@ impl XRRigidTransform { &window.global(), proto, transform, + can_gc, )) } } |