diff options
| author | Josh Matthews <josh@joshmatthews.net> | 2024-08-22 07:42:36 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-22 11:42:36 +0000 |
| commit | 60ef6bc46125d34e492a4294622e2791f3c619b5 (patch) | |
| tree | 8bc8a90f3a4647a7d6565065a8d73bd1b8f29d3d /components/script/dom/xrray.rs | |
| parent | 9a1051c9170abc8e40c43b2a6be712a3ff4b523f (diff) | |
| download | servo-60ef6bc46125d34e492a4294622e2791f3c619b5.tar.gz servo-60ef6bc46125d34e492a4294622e2791f3c619b5.zip | |
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Propagate CanGc from reflect_dom_object_with_proto.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Mark DOM constructors as GC operations.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/xrray.rs')
| -rw-r--r-- | components/script/dom/xrray.rs | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/components/script/dom/xrray.rs b/components/script/dom/xrray.rs index b1d699761bd..094d8940953 100644 --- a/components/script/dom/xrray.rs +++ b/components/script/dom/xrray.rs @@ -18,7 +18,7 @@ use crate::dom::dompointreadonly::DOMPointReadOnly; use crate::dom::globalscope::GlobalScope; use crate::dom::window::Window; use crate::dom::xrrigidtransform::XRRigidTransform; -use crate::script_runtime::JSContext; +use crate::script_runtime::{CanGc, JSContext}; #[dom_struct] pub struct XRRay { @@ -43,8 +43,9 @@ impl XRRay { global: &GlobalScope, proto: Option<HandleObject>, ray: Ray<ApiSpace>, + can_gc: CanGc, ) -> DomRoot<XRRay> { - reflect_dom_object_with_proto(Box::new(XRRay::new_inherited(ray)), global, proto) + reflect_dom_object_with_proto(Box::new(XRRay::new_inherited(ray)), global, proto, can_gc) } #[allow(non_snake_case)] @@ -52,6 +53,7 @@ impl XRRay { pub fn Constructor( window: &Window, proto: Option<HandleObject>, + can_gc: CanGc, origin: &DOMPointInit, direction: &XRRayDirectionInit, ) -> Fallible<DomRoot<Self>> { @@ -79,6 +81,7 @@ impl XRRay { &window.global(), proto, Ray { origin, direction }, + can_gc, )) } @@ -87,6 +90,7 @@ impl XRRay { pub fn Constructor_( window: &Window, proto: Option<HandleObject>, + can_gc: CanGc, transform: &XRRigidTransform, ) -> Fallible<DomRoot<Self>> { let transform = transform.transform(); @@ -99,6 +103,7 @@ impl XRRay { &window.global(), proto, Ray { origin, direction }, + can_gc, )) } |