diff options
author | bors-servo <metajack+bors@gmail.com> | 2015-05-20 15:42:06 -0500 |
---|---|---|
committer | bors-servo <metajack+bors@gmail.com> | 2015-05-20 15:42:06 -0500 |
commit | ad53e95080144485e74cd9b9d48ce75e20de4e36 (patch) | |
tree | 623ce11dac7f48f6f61326adf9796ba7db35cd01 /components/script/dom/websocket.rs | |
parent | fada39164cbaba3a9885f08fad6f10a2353a4838 (diff) | |
parent | 3350522306ee087f892108ee82aeb9d58ee2363d (diff) | |
download | servo-ad53e95080144485e74cd9b9d48ce75e20de4e36.tar.gz servo-ad53e95080144485e74cd9b9d48ce75e20de4e36.zip |
Auto merge of #6083 - ecoal95:layerize-canvas, r=pcwalton
I've done a bit of job to get this done. Right now readback is still used, but we have a `LayerId` -> `CanvasRenderer` map on the paint task, that we can use to get rid of that.
I'd want review, to see if this is a good approach (I know it's not the initial `CanvasId` -> renderer approach, but it's pretty similar, since a canvas involves a `PaintLayer`).
I had to do a bit of refactoring to avoid cyclic dependencies between canvas and gfx. I'd want you to review them too.
It's mergeable and doesn't break any tests :P
Some of my main concerns:
* Does the canvas render really need to be behind an `Arc<Mutex<T>>`?
* I can't clone a `NativeSurface` right now (that's why the `SendNativeSurface()` msg is unimplemented in the WebGL task). It should be easy to add that to rust-layers, supposing the caller is responsible to mark it as non-leaking, any reason to not do it?
cc @jdm @pcwalton
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6083)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/websocket.rs')
0 files changed, 0 insertions, 0 deletions