diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2015-12-11 21:12:35 +0530 |
|---|---|---|
| committer | bors-servo <lbergstrom+bors@mozilla.com> | 2015-12-11 21:12:35 +0530 |
| commit | 99fd946130c9f06433b47c7f60241d5f7ad14a5b (patch) | |
| tree | 1603ff8f033a23e729862f0af9d2c036afd2e035 /components/script/dom/websocket.rs | |
| parent | f5eec35cb47722f35cb1412eab2c096bb22fd6cc (diff) | |
| parent | 4accaf50b21a6344e9ee7518f7ab07c1dde7c36c (diff) | |
| download | servo-99fd946130c9f06433b47c7f60241d5f7ad14a5b.tar.gz servo-99fd946130c9f06433b47c7f60241d5f7ad14a5b.zip | |
Auto merge of #8930 - frewsxcv:event-type-atom, r=nox
Pass around event types as Atoms instead of Strings
`Event` internally stores the `type` as an `Atom`, and we're `String`s
everywhere, which can cause unnecessary allocations to occur since
they'll end up as `Atom`s anyways.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8930)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/websocket.rs')
| -rw-r--r-- | components/script/dom/websocket.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/components/script/dom/websocket.rs b/components/script/dom/websocket.rs index 125ab9065ee..8d7e5ebd6c6 100644 --- a/components/script/dom/websocket.rs +++ b/components/script/dom/websocket.rs @@ -464,7 +464,7 @@ impl Runnable for ConnectionEstablishedTask { // Step 6. let global = ws.global.root(); - let event = Event::new(global.r(), DOMString::from("open"), + let event = Event::new(global.r(), atom!("open"), EventBubbles::DoesNotBubble, EventCancelable::NotCancelable); event.fire(ws.upcast()); @@ -506,7 +506,7 @@ impl Runnable for CloseTask { //A Bad close ws.clean_close.set(false); let event = Event::new(global.r(), - DOMString::from("error"), + atom!("error"), EventBubbles::DoesNotBubble, EventCancelable::Cancelable); event.fire(ws.upcast()); @@ -516,7 +516,7 @@ impl Runnable for CloseTask { https://html.spec.whatwg.org/multipage/#closeWebSocket */ let close_event = CloseEvent::new(global.r(), - DOMString::from("close"), + atom!("close"), EventBubbles::DoesNotBubble, EventCancelable::NotCancelable, ws.clean_close.get(), |