diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-04-01 23:57:19 +0530 |
|---|---|---|
| committer | bors-servo <lbergstrom+bors@mozilla.com> | 2016-04-01 23:57:19 +0530 |
| commit | 4e4a213c73d49641fdfbf83c31152295d4856ae0 (patch) | |
| tree | fd04b79507b5e0eb30f974b4aefae81fb3d3735e /components/script/dom/webidls/HTMLScriptElement.webidl | |
| parent | 7d79df4a05948e0ce6e3abc6bef0f833d8bf541e (diff) | |
| parent | 30555812dc96be45eccfa4cd3e5e177017936cfc (diff) | |
| download | servo-4e4a213c73d49641fdfbf83c31152295d4856ae0.tar.gz servo-4e4a213c73d49641fdfbf83c31152295d4856ae0.zip | |
Auto merge of #9911 - magni-:dont_use_lookup_tables, r=michaelwu
Do not use lookup tables for put_image_data
Fixes #9599
"This is the first Rust code I have ever written" (and also my first time writing real browser code, it's been quite the learning experience).
Some questions:
> For really fast CPU results, use integer SIMD instructions to handle more than one pixel at a time.
This was out of the scope of #9599, right? I started looking into doing that, but it seems to be a lot more work than the `E-easy` label would suggest. [`std::simd`](https://doc.rust-lang.org/1.0.0/std/simd/index.html) is marked as "unstable", is that a blocker?
> 128 can be added before dividing to round more accurately.
@michaelwu, what did you mean by that?
Also, the #9599 is `Do not use lookup tables for {Get,Put}ImageData operations`, but we only use lookup tables for the `Put`, not the `Get`, right?
Sorry for all the noobish questions.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9911)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/webidls/HTMLScriptElement.webidl')
0 files changed, 0 insertions, 0 deletions