aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/webidls/HTMLFormElement.webidl
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2020-01-10 15:18:10 -0500
committerGitHub <noreply@github.com>2020-01-10 15:18:10 -0500
commitfdfc840baca427f58daaa251100c3940256e86c5 (patch)
treedf81b7e1e8df96086926078a9c8b4b91161be558 /components/script/dom/webidls/HTMLFormElement.webidl
parent2aae85b0a0b61350fe946f6b75ed31cd1d5ea30f (diff)
parent111ede9c77a41ab353f12683a62cd4b4dabb65da (diff)
downloadservo-fdfc840baca427f58daaa251100c3940256e86c5.tar.gz
servo-fdfc840baca427f58daaa251100c3940256e86c5.zip
Auto merge of #25446 - pshaughn:fixme11868, r=jdm
Make getOwnPropertyDescriptor hold the correct value for indexed/named properties This is towards #25036 and #25415; it could have far-reaching implications so I want to test it in isolation and see the results on the full test suite. A few lines of code had a FIXME(#11868) despite that issue being closed, and looking for the pattern that was marked that way, I found one other unmarked instance of it. It doesn't immediately crash, and maybe it will pass some tests or fail some tests in informative ways. EDIT: After adding an overlooked extended attribute to HTMLFormElement, this works very well indeed and seems to be worth merging! --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25036 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/webidls/HTMLFormElement.webidl')
-rw-r--r--components/script/dom/webidls/HTMLFormElement.webidl2
1 files changed, 1 insertions, 1 deletions
diff --git a/components/script/dom/webidls/HTMLFormElement.webidl b/components/script/dom/webidls/HTMLFormElement.webidl
index 13ffbf4dfe8..744f6d84ca9 100644
--- a/components/script/dom/webidls/HTMLFormElement.webidl
+++ b/components/script/dom/webidls/HTMLFormElement.webidl
@@ -3,7 +3,7 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
// https://html.spec.whatwg.org/multipage/#htmlformelement
-[Exposed=Window]
+[Exposed=Window, LegacyUnenumerableNamedProperties]
interface HTMLFormElement : HTMLElement {
[HTMLConstructor] constructor();