diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-09-16 20:34:25 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-09-16 20:34:25 -0500 |
commit | 2fb4dd9ec3bb4be7d5ea8404964536c89fc8732b (patch) | |
tree | 3d3a2e78c5a6261606a546caed892b121f6c0b8f /components/script/dom/webidls/ExtendableMessageEvent.webidl | |
parent | 949d2c4bc4b0a18d13444864cb70dd59946a18d8 (diff) | |
parent | a9de84ab49953be44d772eedc5f165d91e30d189 (diff) | |
download | servo-2fb4dd9ec3bb4be7d5ea8404964536c89fc8732b.tar.gz servo-2fb4dd9ec3bb4be7d5ea8404964536c89fc8732b.zip |
Auto merge of #12703 - sjmelia:12343_test_activation, r=Manishearth
Fix Issue 12343: Add pref-gated methods and test for activatable element
<!-- Please describe your changes on the following line: -->
Add methods to activatable elements; gated by a preference, for use in servo-specific WPT tests.
I cargo-culted over the "redundant check" from #12322, I don't really understand the possible exploit.
Obvious flaw is the copypasta for each element. I understand that the webidl codegen will produce a trait for ActivatableElement, but I can't see how I can provide a default implementation for this? I guess otherwise could be an improvement to have each element just delegate to an Enter.../Exit... method on the Activatable trait?
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12343 (github issue number if applicable).
<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
…states
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12703)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/webidls/ExtendableMessageEvent.webidl')
0 files changed, 0 insertions, 0 deletions