diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2020-03-05 12:26:47 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-03-05 12:26:47 -0500 |
commit | ca25e18791163de5c6af1267d876c7f5bb705f61 (patch) | |
tree | c8bcf95960c8cd43ebe2c4a1a533eb98c6e9ec49 /components/script/dom/webglframebuffer.rs | |
parent | 813be919269f632ba23746e4700e8a18bdd4ae07 (diff) | |
parent | 5cb6eb274450b1418dab9e417fe4a58edc09b7f1 (diff) | |
download | servo-ca25e18791163de5c6af1267d876c7f5bb705f61.tar.gz servo-ca25e18791163de5c6af1267d876c7f5bb705f61.zip |
Auto merge of #25903 - mmatyas:webgl_fns_framebuf_render_validation_fix, r=jdm
Improved the WebGL2 framebuffer render validation
It seems `MissingColorAttachment` should be returned only when all of the color attachments are missing.
<!-- Please describe your changes on the following line: -->
cc @jdm @zakorgy
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/webglframebuffer.rs')
-rw-r--r-- | components/script/dom/webglframebuffer.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/script/dom/webglframebuffer.rs b/components/script/dom/webglframebuffer.rs index 51604d3e415..c285145d994 100644 --- a/components/script/dom/webglframebuffer.rs +++ b/components/script/dom/webglframebuffer.rs @@ -468,7 +468,7 @@ impl WebGLFramebuffer { return CompleteForRendering::Complete; } - if self.colors.iter().any(|att| att.borrow().is_none()) { + if self.colors.iter().all(|att| att.borrow().is_none()) { return CompleteForRendering::MissingColorAttachment; } |