diff options
author | Simon Sapin <simon.sapin@exyr.org> | 2017-10-16 14:35:30 +0200 |
---|---|---|
committer | Simon Sapin <simon.sapin@exyr.org> | 2017-10-16 17:16:20 +0200 |
commit | aa15dc269f41503d81ad44cd7e85d69e6f4aeac7 (patch) | |
tree | 981d8d64c8de6ffd4c9e855553f34b6d09856d88 /components/script/dom/webgl_extensions/ext | |
parent | a5100e3c783f140c368da89e25e50581dce91bfd (diff) | |
download | servo-aa15dc269f41503d81ad44cd7e85d69e6f4aeac7.tar.gz servo-aa15dc269f41503d81ad44cd7e85d69e6f4aeac7.zip |
Remove use of unstable box syntax.
http://www.robohornet.org gives a score of 101.36 on master,
and 102.68 with this PR. The latter is slightly better,
but probably within noise level.
So it looks like this PR does not affect DOM performance.
This is expected since `Box::new` is defined as:
```rust
impl<T> Box<T> {
#[inline(always)]
pub fn new(x: T) -> Box<T> {
box x
}
}
```
With inlining, it should compile to the same as box syntax.
Diffstat (limited to 'components/script/dom/webgl_extensions/ext')
7 files changed, 7 insertions, 7 deletions
diff --git a/components/script/dom/webgl_extensions/ext/oesstandardderivatives.rs b/components/script/dom/webgl_extensions/ext/oesstandardderivatives.rs index 3740db14751..6ede450e621 100644 --- a/components/script/dom/webgl_extensions/ext/oesstandardderivatives.rs +++ b/components/script/dom/webgl_extensions/ext/oesstandardderivatives.rs @@ -26,7 +26,7 @@ impl OESStandardDerivatives { impl WebGLExtension for OESStandardDerivatives { type Extension = OESStandardDerivatives; fn new(ctx: &WebGLRenderingContext) -> DomRoot<OESStandardDerivatives> { - reflect_dom_object(box OESStandardDerivatives::new_inherited(), + reflect_dom_object(Box::new(OESStandardDerivatives::new_inherited()), &*ctx.global(), OESStandardDerivativesBinding::Wrap) } diff --git a/components/script/dom/webgl_extensions/ext/oestexturefloat.rs b/components/script/dom/webgl_extensions/ext/oestexturefloat.rs index 967df546cc9..53233905857 100644 --- a/components/script/dom/webgl_extensions/ext/oestexturefloat.rs +++ b/components/script/dom/webgl_extensions/ext/oestexturefloat.rs @@ -25,7 +25,7 @@ impl OESTextureFloat { impl WebGLExtension for OESTextureFloat { type Extension = OESTextureFloat; fn new(ctx: &WebGLRenderingContext) -> DomRoot<OESTextureFloat> { - reflect_dom_object(box OESTextureFloat::new_inherited(), + reflect_dom_object(Box::new(OESTextureFloat::new_inherited()), &*ctx.global(), OESTextureFloatBinding::Wrap) } diff --git a/components/script/dom/webgl_extensions/ext/oestexturefloatlinear.rs b/components/script/dom/webgl_extensions/ext/oestexturefloatlinear.rs index 2a730f2e85f..ec7a02b34bb 100644 --- a/components/script/dom/webgl_extensions/ext/oestexturefloatlinear.rs +++ b/components/script/dom/webgl_extensions/ext/oestexturefloatlinear.rs @@ -25,7 +25,7 @@ impl OESTextureFloatLinear { impl WebGLExtension for OESTextureFloatLinear { type Extension = OESTextureFloatLinear; fn new(ctx: &WebGLRenderingContext) -> DomRoot<OESTextureFloatLinear> { - reflect_dom_object(box OESTextureFloatLinear::new_inherited(), + reflect_dom_object(Box::new(OESTextureFloatLinear::new_inherited()), &*ctx.global(), OESTextureFloatLinearBinding::Wrap) } diff --git a/components/script/dom/webgl_extensions/ext/oestexturehalffloat.rs b/components/script/dom/webgl_extensions/ext/oestexturehalffloat.rs index f5db59e097d..a9e32c7a8f5 100644 --- a/components/script/dom/webgl_extensions/ext/oestexturehalffloat.rs +++ b/components/script/dom/webgl_extensions/ext/oestexturehalffloat.rs @@ -25,7 +25,7 @@ impl OESTextureHalfFloat { impl WebGLExtension for OESTextureHalfFloat { type Extension = OESTextureHalfFloat; fn new(ctx: &WebGLRenderingContext) -> DomRoot<OESTextureHalfFloat> { - reflect_dom_object(box OESTextureHalfFloat::new_inherited(), + reflect_dom_object(Box::new(OESTextureHalfFloat::new_inherited()), &*ctx.global(), OESTextureHalfFloatBinding::Wrap) } diff --git a/components/script/dom/webgl_extensions/ext/oestexturehalffloatlinear.rs b/components/script/dom/webgl_extensions/ext/oestexturehalffloatlinear.rs index 52f15ada5c2..a94702321eb 100644 --- a/components/script/dom/webgl_extensions/ext/oestexturehalffloatlinear.rs +++ b/components/script/dom/webgl_extensions/ext/oestexturehalffloatlinear.rs @@ -26,7 +26,7 @@ impl OESTextureHalfFloatLinear { impl WebGLExtension for OESTextureHalfFloatLinear { type Extension = OESTextureHalfFloatLinear; fn new(ctx: &WebGLRenderingContext) -> DomRoot<OESTextureHalfFloatLinear> { - reflect_dom_object(box OESTextureHalfFloatLinear::new_inherited(), + reflect_dom_object(Box::new(OESTextureHalfFloatLinear::new_inherited()), &*ctx.global(), OESTextureHalfFloatLinearBinding::Wrap) } diff --git a/components/script/dom/webgl_extensions/ext/oesvertexarrayobject.rs b/components/script/dom/webgl_extensions/ext/oesvertexarrayobject.rs index cf2f3ab0f50..9ba3f4709ab 100644 --- a/components/script/dom/webgl_extensions/ext/oesvertexarrayobject.rs +++ b/components/script/dom/webgl_extensions/ext/oesvertexarrayobject.rs @@ -133,7 +133,7 @@ impl OESVertexArrayObjectMethods for OESVertexArrayObject { impl WebGLExtension for OESVertexArrayObject { type Extension = OESVertexArrayObject; fn new(ctx: &WebGLRenderingContext) -> DomRoot<OESVertexArrayObject> { - reflect_dom_object(box OESVertexArrayObject::new_inherited(ctx), + reflect_dom_object(Box::new(OESVertexArrayObject::new_inherited(ctx)), &*ctx.global(), OESVertexArrayObjectBinding::Wrap) } diff --git a/components/script/dom/webgl_extensions/ext/webglvertexarrayobjectoes.rs b/components/script/dom/webgl_extensions/ext/webglvertexarrayobjectoes.rs index 8433b345328..70ed5a6f778 100644 --- a/components/script/dom/webgl_extensions/ext/webglvertexarrayobjectoes.rs +++ b/components/script/dom/webgl_extensions/ext/webglvertexarrayobjectoes.rs @@ -39,7 +39,7 @@ impl WebGLVertexArrayObjectOES { } pub fn new(global: &GlobalScope, id: WebGLVertexArrayId) -> DomRoot<WebGLVertexArrayObjectOES> { - reflect_dom_object(box WebGLVertexArrayObjectOES::new_inherited(id), + reflect_dom_object(Box::new(WebGLVertexArrayObjectOES::new_inherited(id)), global, WebGLVertexArrayObjectOESBinding::Wrap) } |