aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/trackevent.rs
diff options
context:
space:
mode:
authorJosh Matthews <josh@joshmatthews.net>2024-08-22 07:42:36 -0400
committerGitHub <noreply@github.com>2024-08-22 11:42:36 +0000
commit60ef6bc46125d34e492a4294622e2791f3c619b5 (patch)
tree8bc8a90f3a4647a7d6565065a8d73bd1b8f29d3d /components/script/dom/trackevent.rs
parent9a1051c9170abc8e40c43b2a6be712a3ff4b523f (diff)
downloadservo-60ef6bc46125d34e492a4294622e2791f3c619b5.tar.gz
servo-60ef6bc46125d34e492a4294622e2791f3c619b5.zip
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Propagate CanGc from reflect_dom_object_with_proto. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Mark DOM constructors as GC operations. Signed-off-by: Josh Matthews <josh@joshmatthews.net> --------- Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/trackevent.rs')
-rw-r--r--components/script/dom/trackevent.rs15
1 files changed, 14 insertions, 1 deletions
diff --git a/components/script/dom/trackevent.rs b/components/script/dom/trackevent.rs
index f0d740d06dd..cb74fff1f93 100644
--- a/components/script/dom/trackevent.rs
+++ b/components/script/dom/trackevent.rs
@@ -21,6 +21,7 @@ use crate::dom::globalscope::GlobalScope;
use crate::dom::texttrack::TextTrack;
use crate::dom::videotrack::VideoTrack;
use crate::dom::window::Window;
+use crate::script_runtime::CanGc;
#[crown::unrooted_must_root_lint::must_root]
#[derive(JSTraceable, MallocSizeOf)]
@@ -66,7 +67,15 @@ impl TrackEvent {
cancelable: bool,
track: &Option<VideoTrackOrAudioTrackOrTextTrack>,
) -> DomRoot<TrackEvent> {
- Self::new_with_proto(global, None, type_, bubbles, cancelable, track)
+ Self::new_with_proto(
+ global,
+ None,
+ type_,
+ bubbles,
+ cancelable,
+ track,
+ CanGc::note(),
+ )
}
fn new_with_proto(
@@ -76,11 +85,13 @@ impl TrackEvent {
bubbles: bool,
cancelable: bool,
track: &Option<VideoTrackOrAudioTrackOrTextTrack>,
+ can_gc: CanGc,
) -> DomRoot<TrackEvent> {
let te = reflect_dom_object_with_proto(
Box::new(TrackEvent::new_inherited(track)),
global,
proto,
+ can_gc,
);
{
let event = te.upcast::<Event>();
@@ -92,6 +103,7 @@ impl TrackEvent {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
+ can_gc: CanGc,
type_: DOMString,
init: &TrackEventBinding::TrackEventInit,
) -> Fallible<DomRoot<TrackEvent>> {
@@ -102,6 +114,7 @@ impl TrackEvent {
init.parent.bubbles,
init.parent.cancelable,
&init.track,
+ can_gc,
))
}
}