aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/timeranges.rs
diff options
context:
space:
mode:
authorFernando Jiménez Moreno <ferjmoreno@gmail.com>2019-01-15 13:15:03 +0100
committerFernando Jiménez Moreno <ferjmoreno@gmail.com>2019-01-17 10:01:38 +0100
commit4b23c631ea9210fab34bb66d3edce9f63d5f99d1 (patch)
treec73a7031f2d16ecdfd255985cf4cf86402715e9c /components/script/dom/timeranges.rs
parentf5581a78ab5a2581922a719f54037ca2577ed1ad (diff)
downloadservo-4b23c631ea9210fab34bb66d3edce9f63d5f99d1.tar.gz
servo-4b23c631ea9210fab34bb66d3edce9f63d5f99d1.zip
No need to share a reference for HTMLMediaElement played TimeRange
Diffstat (limited to 'components/script/dom/timeranges.rs')
-rw-r--r--components/script/dom/timeranges.rs16
1 files changed, 4 insertions, 12 deletions
diff --git a/components/script/dom/timeranges.rs b/components/script/dom/timeranges.rs
index 645de7b5799..7b4d1978a60 100644
--- a/components/script/dom/timeranges.rs
+++ b/components/script/dom/timeranges.rs
@@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
-use crate::dom::bindings::cell::DomRefCell;
use crate::dom::bindings::codegen::Bindings::TimeRangesBinding;
use crate::dom::bindings::codegen::Bindings::TimeRangesBinding::TimeRangesMethods;
use crate::dom::bindings::error::{Error, Fallible};
@@ -12,7 +11,6 @@ use crate::dom::bindings::root::DomRoot;
use crate::dom::window::Window;
use dom_struct::dom_struct;
use std::fmt;
-use std::rc::Rc;
#[derive(Clone, JSTraceable, MallocSizeOf)]
struct TimeRange {
@@ -128,22 +126,18 @@ impl TimeRangesContainer {
#[dom_struct]
pub struct TimeRanges {
reflector_: Reflector,
- #[ignore_malloc_size_of = "Rc"]
- ranges: Rc<DomRefCell<TimeRangesContainer>>,
+ ranges: TimeRangesContainer,
}
impl TimeRanges {
- fn new_inherited(ranges: Rc<DomRefCell<TimeRangesContainer>>) -> TimeRanges {
+ fn new_inherited(ranges: TimeRangesContainer) -> TimeRanges {
Self {
reflector_: Reflector::new(),
ranges,
}
}
- pub fn new(
- window: &Window,
- ranges: Rc<DomRefCell<TimeRangesContainer>>,
- ) -> DomRoot<TimeRanges> {
+ pub fn new(window: &Window, ranges: TimeRangesContainer) -> DomRoot<TimeRanges> {
reflect_dom_object(
Box::new(TimeRanges::new_inherited(ranges)),
window,
@@ -155,13 +149,12 @@ impl TimeRanges {
impl TimeRangesMethods for TimeRanges {
// https://html.spec.whatwg.org/multipage/#dom-timeranges-length
fn Length(&self) -> u32 {
- self.ranges.borrow().len()
+ self.ranges.len()
}
// https://html.spec.whatwg.org/multipage/#dom-timeranges-start
fn Start(&self, index: u32) -> Fallible<Finite<f64>> {
self.ranges
- .borrow()
.start(index)
.map(Finite::wrap)
.map_err(|_| Error::IndexSize)
@@ -170,7 +163,6 @@ impl TimeRangesMethods for TimeRanges {
// https://html.spec.whatwg.org/multipage/#dom-timeranges-end
fn End(&self, index: u32) -> Fallible<Finite<f64>> {
self.ranges
- .borrow()
.end(index)
.map(Finite::wrap)
.map_err(|_| Error::IndexSize)