diff options
author | Josh Matthews <josh@joshmatthews.net> | 2024-08-22 07:42:36 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-08-22 11:42:36 +0000 |
commit | 60ef6bc46125d34e492a4294622e2791f3c619b5 (patch) | |
tree | 8bc8a90f3a4647a7d6565065a8d73bd1b8f29d3d /components/script/dom/testbinding.rs | |
parent | 9a1051c9170abc8e40c43b2a6be712a3ff4b523f (diff) | |
download | servo-60ef6bc46125d34e492a4294622e2791f3c619b5.tar.gz servo-60ef6bc46125d34e492a4294622e2791f3c619b5.zip |
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Propagate CanGc from reflect_dom_object_with_proto.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Mark DOM constructors as GC operations.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/testbinding.rs')
-rw-r--r-- | components/script/dom/testbinding.rs | 24 |
1 files changed, 18 insertions, 6 deletions
diff --git a/components/script/dom/testbinding.rs b/components/script/dom/testbinding.rs index 0177a6d89d1..a1d260f6a98 100644 --- a/components/script/dom/testbinding.rs +++ b/components/script/dom/testbinding.rs @@ -49,7 +49,7 @@ use crate::dom::promise::Promise; use crate::dom::promisenativehandler::{Callback, PromiseNativeHandler}; use crate::dom::url::URL; use crate::realms::InRealm; -use crate::script_runtime::JSContext as SafeJSContext; +use crate::script_runtime::{CanGc, JSContext as SafeJSContext}; use crate::timers::OneshotTimerCallback; #[dom_struct] @@ -67,33 +67,45 @@ impl TestBinding { } } - fn new(global: &GlobalScope, proto: Option<HandleObject>) -> DomRoot<TestBinding> { - reflect_dom_object_with_proto(Box::new(TestBinding::new_inherited()), global, proto) + fn new( + global: &GlobalScope, + proto: Option<HandleObject>, + can_gc: CanGc, + ) -> DomRoot<TestBinding> { + reflect_dom_object_with_proto( + Box::new(TestBinding::new_inherited()), + global, + proto, + can_gc, + ) } pub fn Constructor( global: &GlobalScope, proto: Option<HandleObject>, + can_gc: CanGc, ) -> Fallible<DomRoot<TestBinding>> { - Ok(TestBinding::new(global, proto)) + Ok(TestBinding::new(global, proto, can_gc)) } #[allow(unused_variables)] pub fn Constructor_( global: &GlobalScope, proto: Option<HandleObject>, + can_gc: CanGc, nums: Vec<f64>, ) -> Fallible<DomRoot<TestBinding>> { - Ok(TestBinding::new(global, proto)) + Ok(TestBinding::new(global, proto, can_gc)) } #[allow(unused_variables)] pub fn Constructor__( global: &GlobalScope, proto: Option<HandleObject>, + can_gc: CanGc, num: f64, ) -> Fallible<DomRoot<TestBinding>> { - Ok(TestBinding::new(global, proto)) + Ok(TestBinding::new(global, proto, can_gc)) } } |