diff options
author | Josh Matthews <josh@joshmatthews.net> | 2024-08-22 07:42:36 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-08-22 11:42:36 +0000 |
commit | 60ef6bc46125d34e492a4294622e2791f3c619b5 (patch) | |
tree | 8bc8a90f3a4647a7d6565065a8d73bd1b8f29d3d /components/script/dom/submitevent.rs | |
parent | 9a1051c9170abc8e40c43b2a6be712a3ff4b523f (diff) | |
download | servo-60ef6bc46125d34e492a4294622e2791f3c619b5.tar.gz servo-60ef6bc46125d34e492a4294622e2791f3c619b5.zip |
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Propagate CanGc from reflect_dom_object_with_proto.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Mark DOM constructors as GC operations.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/submitevent.rs')
-rw-r--r-- | components/script/dom/submitevent.rs | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/components/script/dom/submitevent.rs b/components/script/dom/submitevent.rs index 9f2f3dd6fc3..5f3ee07fca3 100644 --- a/components/script/dom/submitevent.rs +++ b/components/script/dom/submitevent.rs @@ -17,6 +17,7 @@ use crate::dom::event::Event; use crate::dom::globalscope::GlobalScope; use crate::dom::htmlelement::HTMLElement; use crate::dom::window::Window; +use crate::script_runtime::CanGc; #[dom_struct] #[allow(non_snake_case)] @@ -40,7 +41,15 @@ impl SubmitEvent { cancelable: bool, submitter: Option<DomRoot<HTMLElement>>, ) -> DomRoot<SubmitEvent> { - Self::new_with_proto(global, None, type_, bubbles, cancelable, submitter) + Self::new_with_proto( + global, + None, + type_, + bubbles, + cancelable, + submitter, + CanGc::note(), + ) } fn new_with_proto( @@ -50,11 +59,13 @@ impl SubmitEvent { bubbles: bool, cancelable: bool, submitter: Option<DomRoot<HTMLElement>>, + can_gc: CanGc, ) -> DomRoot<SubmitEvent> { let ev = reflect_dom_object_with_proto( Box::new(SubmitEvent::new_inherited(submitter)), global, proto, + can_gc, ); { let event = ev.upcast::<Event>(); @@ -67,6 +78,7 @@ impl SubmitEvent { pub fn Constructor( window: &Window, proto: Option<HandleObject>, + can_gc: CanGc, type_: DOMString, init: &SubmitEventBinding::SubmitEventInit, ) -> DomRoot<SubmitEvent> { @@ -77,6 +89,7 @@ impl SubmitEvent { init.parent.bubbles, init.parent.cancelable, init.submitter.as_ref().map(|s| DomRoot::from_ref(&**s)), + can_gc, ) } } |