diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2020-02-13 20:11:20 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-02-13 20:11:20 -0500 |
commit | f02053621505c1e290793fb6f27efea38d81fb5b (patch) | |
tree | 87d7c6357efe23f69ebe0ac24cbbcde987da7260 /components/script/dom/shadowroot.rs | |
parent | e697e6cca70bec57b5ed9512b95c2a72359d6ca1 (diff) | |
parent | e48eac6879add4512dd42cbed0216508ace2c31e (diff) | |
download | servo-f02053621505c1e290793fb6f27efea38d81fb5b.tar.gz servo-f02053621505c1e290793fb6f27efea38d81fb5b.zip |
Auto merge of #25548 - pshaughn:docnamedgetter, r=jdm
Add SupportedPropertyNames to Document (also fix iframe getting)
Existing test of named-getting an iframe now succeeds. I added a new test for Object.getOwnPropertyNames(document) based on my understanding of the spec; that test could use a second opinion.
UPDATE: This was trying to do too many things in one PR as originally submitted. It is now using #25572 as a base, and I suggest reviewing that PR before this one to avoid duplicating review effort.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #7273 for all implemented named getters, fix #25146, and fix the iframe case only of #25145.
<!-- Either: -->
- [X] There are tests for these changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/shadowroot.rs')
-rw-r--r-- | components/script/dom/shadowroot.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/components/script/dom/shadowroot.rs b/components/script/dom/shadowroot.rs index d6df87bded8..0b791476f7c 100644 --- a/components/script/dom/shadowroot.rs +++ b/components/script/dom/shadowroot.rs @@ -145,7 +145,7 @@ impl ShadowRoot { /// Remove any existing association between the provided id and any elements /// in this shadow tree. - pub fn unregister_named_element(&self, to_unregister: &Element, id: Atom) { + pub fn unregister_element_id(&self, to_unregister: &Element, id: Atom) { self.document_or_shadow_root.unregister_named_element( self.document_fragment.id_map(), to_unregister, @@ -154,7 +154,7 @@ impl ShadowRoot { } /// Associate an element present in this shadow tree with the provided id. - pub fn register_named_element(&self, element: &Element, id: Atom) { + pub fn register_element_id(&self, element: &Element, id: Atom) { let root = self .upcast::<Node>() .inclusive_ancestors(ShadowIncluding::No) |