diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-01-09 02:46:09 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-01-09 02:46:09 -0800 |
commit | ebd4a8b3ee1aab910ef714420a814912fec31e30 (patch) | |
tree | d84f720d2c7356b615974abeba37831913dc5658 /components/script/dom/servoparser/xml.rs | |
parent | 13826970c4d9fbbd67cdf9dfb39e8a847cf06541 (diff) | |
parent | 3e0e2bcd2c07fa47617907255ed4ee90f203acba (diff) | |
download | servo-ebd4a8b3ee1aab910ef714420a814912fec31e30.tar.gz servo-ebd4a8b3ee1aab910ef714420a814912fec31e30.zip |
Auto merge of #14922 - heycam:pseudo-inherit, r=emilio
Don't inherit all properties for eagerly computed pseudos if there are no matching rules.
<!-- Please describe your changes on the following line: -->
When we resolve style for an eagerly computed pseudo-element, such as an anonymous box, if there are no matching rules we currently just clone the parent's style. We should only do that if `inherit_all` is true, otherwise we should inherit only the inherited properties from the parent.
I was going to use `.unwrap_or_default()` on the result of looking up `precomputed_pseudo_element_decls`, but that didn't seem to work since that map lookup returns a reference and not a `Vec` itself.
r? @emilio
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1329121
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14922)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/servoparser/xml.rs')
0 files changed, 0 insertions, 0 deletions