diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-06-25 10:45:42 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-06-25 10:45:42 -0700 |
commit | 3f2d7476890bffdaad6fdc0e66aa7ac7bc995a87 (patch) | |
tree | bd35f692020c7c3178278b5b85d31b9922066c05 /components/script/dom/servoparser/async_html.rs | |
parent | d8ae4638397a3834203267ceae075509e9cb9931 (diff) | |
parent | 6081241962476ccb7f85dfa251977ecf88f047d7 (diff) | |
download | servo-3f2d7476890bffdaad6fdc0e66aa7ac7bc995a87.tar.gz servo-3f2d7476890bffdaad6fdc0e66aa7ac7bc995a87.zip |
Auto merge of #17514 - HarveyHunt:deny-public-fields-error-message, r=jdm
deny_public_fields: display field identifier in help message
Use a binding's field identifier to produce more descriptive output.
Fall back to a binding's identifier if a field identifier is not
available.
Additionally, make the privatize.rs compiletest more specific and
wrap the identifier in backticks to aid readability.
As an aside, should I send a PR to rename ```compile-fail/privatize.rs``` to ```compile-fail/deny_public_fields.rs``` as privatize isn't mentioned in the codebase any more?
```
$ find . -name "*privatize*"
./tests/compiletest/plugin/compile-fail/privatize.rs
```
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17438 (github issue number if applicable).
<!-- Either: -->
- [x] There are tests for these changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17514)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/servoparser/async_html.rs')
0 files changed, 0 insertions, 0 deletions