diff options
author | bors-servo <infra@servo.org> | 2023-06-22 01:56:56 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-06-22 01:56:56 +0200 |
commit | 7fc6190c3685bcb22be7047ddcbfbff5801883e8 (patch) | |
tree | 392de665307a300d225e11fee6ce5ef93e808735 /components/script/dom/servoparser/async_html.rs | |
parent | 9edc2c664fc4b5e04d8805107369ca0f20081771 (diff) | |
parent | 30ab348116a90e47f2fbb97a0f393c181cbdb175 (diff) | |
download | servo-7fc6190c3685bcb22be7047ddcbfbff5801883e8.tar.gz servo-7fc6190c3685bcb22be7047ddcbfbff5801883e8.zip |
Auto merge of #29899 - mrobinson:absolute-floats, r=Loirooriol
Properly position absolutes with static insets that are children of floats
Previously, final float positions were calculated when their parents
were positioned. This prevented proper positioning of absolute children
of floats with static insets, because they accumulate offsets as they
are hoisted up the tree.
This change moves the final float positioning to
`PlacementState::place_fragment` for the float itself so that it happens
before any insets are updated for hoisted descendants. In addition to
simplifying the code, this makes it a bit more efficient. Finally,
floats are taken into account when updating static insets of hoisted
boxes.
Fixes #29826.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #29826
- [x] There are tests for these changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/servoparser/async_html.rs')
0 files changed, 0 insertions, 0 deletions