diff options
author | Simon Sapin <simon.sapin@exyr.org> | 2017-10-16 14:35:30 +0200 |
---|---|---|
committer | Simon Sapin <simon.sapin@exyr.org> | 2017-10-16 17:16:20 +0200 |
commit | aa15dc269f41503d81ad44cd7e85d69e6f4aeac7 (patch) | |
tree | 981d8d64c8de6ffd4c9e855553f34b6d09856d88 /components/script/dom/range.rs | |
parent | a5100e3c783f140c368da89e25e50581dce91bfd (diff) | |
download | servo-aa15dc269f41503d81ad44cd7e85d69e6f4aeac7.tar.gz servo-aa15dc269f41503d81ad44cd7e85d69e6f4aeac7.zip |
Remove use of unstable box syntax.
http://www.robohornet.org gives a score of 101.36 on master,
and 102.68 with this PR. The latter is slightly better,
but probably within noise level.
So it looks like this PR does not affect DOM performance.
This is expected since `Box::new` is defined as:
```rust
impl<T> Box<T> {
#[inline(always)]
pub fn new(x: T) -> Box<T> {
box x
}
}
```
With inlining, it should compile to the same as box syntax.
Diffstat (limited to 'components/script/dom/range.rs')
-rw-r--r-- | components/script/dom/range.rs | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/components/script/dom/range.rs b/components/script/dom/range.rs index b6a05b31881..00e2d23ce76 100644 --- a/components/script/dom/range.rs +++ b/components/script/dom/range.rs @@ -58,10 +58,13 @@ impl Range { start_container: &Node, start_offset: u32, end_container: &Node, end_offset: u32) -> DomRoot<Range> { - let range = reflect_dom_object(box Range::new_inherited(start_container, start_offset, - end_container, end_offset), - document.window(), - RangeBinding::Wrap); + let range = reflect_dom_object( + Box::new(Range::new_inherited( + start_container, start_offset, end_container, end_offset + )), + document.window(), + RangeBinding::Wrap + ); start_container.ranges().push(WeakRef::new(&range)); if start_container != end_container { end_container.ranges().push(WeakRef::new(&range)); |