diff options
| author | Josh Matthews <josh@joshmatthews.net> | 2024-11-05 03:29:08 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-05 08:29:08 +0000 |
| commit | 25a0764a37a585d032ca352923b24995f8cbf1a0 (patch) | |
| tree | 1805edc4fc79396de9150f8bc063888926d53d3b /components/script/dom/navigator.rs | |
| parent | 537958a3ccb57502c558e4da0963307fd7481a14 (diff) | |
| download | servo-25a0764a37a585d032ca352923b24995f8cbf1a0.tar.gz servo-25a0764a37a585d032ca352923b24995f8cbf1a0.zip | |
Use out parameter for generated methods returning JSVal (#34087)
* Make generated bindings that return a WebIDL `any` value use out parameters.
Returning raw JSVal values makes it easier to create GC hazards in code
that calls these methods. Accepting a MutableHandle argument instead
ensures that the values are rooted by the caller.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Update mozjs.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Fix clippy warnings.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/navigator.rs')
| -rw-r--r-- | components/script/dom/navigator.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/components/script/dom/navigator.rs b/components/script/dom/navigator.rs index 9ef543bfb68..969f006dd76 100644 --- a/components/script/dom/navigator.rs +++ b/components/script/dom/navigator.rs @@ -7,7 +7,7 @@ use std::convert::TryInto; use std::sync::LazyLock; use dom_struct::dom_struct; -use js::jsval::JSVal; +use js::rust::MutableHandleValue; use crate::dom::bindings::cell::DomRefCell; use crate::dom::bindings::codegen::Bindings::NavigatorBinding::NavigatorMethods; @@ -199,8 +199,8 @@ impl NavigatorMethods for Navigator { // https://html.spec.whatwg.org/multipage/#dom-navigator-languages #[allow(unsafe_code)] - fn Languages(&self, cx: JSContext) -> JSVal { - to_frozen_array(&[self.Language()], cx) + fn Languages(&self, cx: JSContext, retval: MutableHandleValue) { + to_frozen_array(&[self.Language()], cx, retval) } // https://html.spec.whatwg.org/multipage/#dom-navigator-plugins |