diff options
author | Josh Matthews <josh@joshmatthews.net> | 2024-08-22 07:42:36 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-08-22 11:42:36 +0000 |
commit | 60ef6bc46125d34e492a4294622e2791f3c619b5 (patch) | |
tree | 8bc8a90f3a4647a7d6565065a8d73bd1b8f29d3d /components/script/dom/mutationobserver.rs | |
parent | 9a1051c9170abc8e40c43b2a6be712a3ff4b523f (diff) | |
download | servo-60ef6bc46125d34e492a4294622e2791f3c619b5.tar.gz servo-60ef6bc46125d34e492a4294622e2791f3c619b5.zip |
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Propagate CanGc from reflect_dom_object_with_proto.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Mark DOM constructors as GC operations.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/mutationobserver.rs')
-rw-r--r-- | components/script/dom/mutationobserver.rs | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/components/script/dom/mutationobserver.rs b/components/script/dom/mutationobserver.rs index 6f870c3bc48..bd5c77d3ec9 100644 --- a/components/script/dom/mutationobserver.rs +++ b/components/script/dom/mutationobserver.rs @@ -22,6 +22,7 @@ use crate::dom::mutationrecord::MutationRecord; use crate::dom::node::{Node, ShadowIncluding}; use crate::dom::window::Window; use crate::microtask::Microtask; +use crate::script_runtime::CanGc; use crate::script_thread::ScriptThread; #[dom_struct] @@ -72,9 +73,10 @@ impl MutationObserver { global: &Window, proto: Option<HandleObject>, callback: Rc<MutationCallback>, + can_gc: CanGc, ) -> DomRoot<MutationObserver> { let boxed_observer = Box::new(MutationObserver::new_inherited(callback)); - reflect_dom_object_with_proto(boxed_observer, global, proto) + reflect_dom_object_with_proto(boxed_observer, global, proto, can_gc) } fn new_inherited(callback: Rc<MutationCallback>) -> MutationObserver { @@ -90,10 +92,11 @@ impl MutationObserver { pub fn Constructor( global: &Window, proto: Option<HandleObject>, + can_gc: CanGc, callback: Rc<MutationCallback>, ) -> Fallible<DomRoot<MutationObserver>> { global.set_exists_mut_observer(); - let observer = MutationObserver::new_with_proto(global, proto, callback); + let observer = MutationObserver::new_with_proto(global, proto, callback, can_gc); ScriptThread::add_mutation_observer(&observer); Ok(observer) } |