diff options
author | Josh Matthews <josh@joshmatthews.net> | 2024-08-22 07:42:36 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-08-22 11:42:36 +0000 |
commit | 60ef6bc46125d34e492a4294622e2791f3c619b5 (patch) | |
tree | 8bc8a90f3a4647a7d6565065a8d73bd1b8f29d3d /components/script/dom/mediametadata.rs | |
parent | 9a1051c9170abc8e40c43b2a6be712a3ff4b523f (diff) | |
download | servo-60ef6bc46125d34e492a4294622e2791f3c619b5.tar.gz servo-60ef6bc46125d34e492a4294622e2791f3c619b5.zip |
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Propagate CanGc from reflect_dom_object_with_proto.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Mark DOM constructors as GC operations.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/mediametadata.rs')
-rw-r--r-- | components/script/dom/mediametadata.rs | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/components/script/dom/mediametadata.rs b/components/script/dom/mediametadata.rs index f23aac0d4e6..ef647d20982 100644 --- a/components/script/dom/mediametadata.rs +++ b/components/script/dom/mediametadata.rs @@ -15,6 +15,7 @@ use crate::dom::bindings::root::{DomRoot, MutNullableDom}; use crate::dom::bindings::str::DOMString; use crate::dom::mediasession::MediaSession; use crate::dom::window::Window; +use crate::script_runtime::CanGc; #[dom_struct] pub struct MediaMetadata { @@ -37,15 +38,21 @@ impl MediaMetadata { } pub fn new(global: &Window, init: &MediaMetadataInit) -> DomRoot<MediaMetadata> { - Self::new_with_proto(global, None, init) + Self::new_with_proto(global, None, init, CanGc::note()) } fn new_with_proto( global: &Window, proto: Option<HandleObject>, init: &MediaMetadataInit, + can_gc: CanGc, ) -> DomRoot<MediaMetadata> { - reflect_dom_object_with_proto(Box::new(MediaMetadata::new_inherited(init)), global, proto) + reflect_dom_object_with_proto( + Box::new(MediaMetadata::new_inherited(init)), + global, + proto, + can_gc, + ) } /// <https://w3c.github.io/mediasession/#dom-mediametadata-mediametadata> @@ -53,9 +60,10 @@ impl MediaMetadata { pub fn Constructor( window: &Window, proto: Option<HandleObject>, + can_gc: CanGc, init: &MediaMetadataInit, ) -> Fallible<DomRoot<MediaMetadata>> { - Ok(MediaMetadata::new_with_proto(window, proto, init)) + Ok(MediaMetadata::new_with_proto(window, proto, init, can_gc)) } fn queue_update_metadata_algorithm(&self) { |