diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-06-15 15:42:38 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-06-15 15:42:38 -0700 |
| commit | 8fd7dc80c40440b88f42b8f1036ef67483dd93f0 (patch) | |
| tree | 1b6bc8536f643d244a874a5787266fc8be1c69f8 /components/script/dom/htmltableelement.rs | |
| parent | 0142d193a3fde057718612028d9c1676e046b816 (diff) | |
| parent | ead828d992c411b61594cb91400e9f6f26772bfe (diff) | |
| download | servo-8fd7dc80c40440b88f42b8f1036ef67483dd93f0.tar.gz servo-8fd7dc80c40440b88f42b8f1036ef67483dd93f0.zip | |
Auto merge of #17340 - hinaria:master, r=jdm
windows: fix line height handling
hi there!
on windows, this change properly scales a font's line height by its size.
previously, line height was not scaled to the font's size at all, which meant line heights become worse and worse the further you scaled away from the font's design size (in either direction, larger or smaller).
this change makes the `line_gap` ratio and size scale with the font size. i've hand checked that the new computed `line_gap` matches the effective heights in chrome and firefox when `line-height = normal` for a bunch of system fonts. (servo's rendering quality on windows is a different story, though).
i believe this also solves #16476.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17340)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/htmltableelement.rs')
0 files changed, 0 insertions, 0 deletions