diff options
author | Dongie Agnir <dongie.agnir@gmail.com> | 2015-10-27 15:20:35 -1000 |
---|---|---|
committer | Dongie Agnir <dongie.agnir@gmail.com> | 2015-10-27 15:20:35 -1000 |
commit | 4849033297815625939d2f7d8f68a14adfaa5477 (patch) | |
tree | 257899f5371560ff2bd4800cbd2ed1fa4750d6f0 /components/script/dom/htmlselectelement.rs | |
parent | 92e008307fe810ff9762d98b261e88f2040d1d5c (diff) | |
download | servo-4849033297815625939d2f7d8f68a14adfaa5477.tar.gz servo-4849033297815625939d2f7d8f68a14adfaa5477.zip |
Add fixes based on review.
- Use if let instead of match for Option
- Refactor common code into pick_if_selected_and_reset
Diffstat (limited to 'components/script/dom/htmlselectelement.rs')
-rw-r--r-- | components/script/dom/htmlselectelement.rs | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/components/script/dom/htmlselectelement.rs b/components/script/dom/htmlselectelement.rs index 4fd69b390db..04a3d174108 100644 --- a/components/script/dom/htmlselectelement.rs +++ b/components/script/dom/htmlselectelement.rs @@ -70,13 +70,12 @@ impl HTMLSelectElement { } } - match last_selected { - Some(last_selected) => last_selected.set_selectedness(true), - None => { - if self.display_size() == 1 { - if let Some(first_enabled) = first_enabled { - first_enabled.set_selectedness(true); - } + if let Some(last_selected) = last_selected { + last_selected.set_selectedness(true); + } else { + if self.display_size() == 1 { + if let Some(first_enabled) = first_enabled { + first_enabled.set_selectedness(true); } } } |