aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/htmlscriptelement.rs
diff options
context:
space:
mode:
authorMs2ger <Ms2ger@gmail.com>2016-07-15 17:38:29 +0200
committerMs2ger <Ms2ger@gmail.com>2016-07-16 12:33:52 +0200
commitb65240d730ade257f931149b4cc6dab0be6d8191 (patch)
tree3c7bc0b3f505fa0e0f73615e7dc2ca515efeae72 /components/script/dom/htmlscriptelement.rs
parent91b9bcd12572757ed32fcbf446f37bbf8ce43a74 (diff)
downloadservo-b65240d730ade257f931149b4cc6dab0be6d8191.tar.gz
servo-b65240d730ade257f931149b4cc6dab0be6d8191.zip
Stop destructuring load in HTMLScriptElement::execute().
Diffstat (limited to 'components/script/dom/htmlscriptelement.rs')
-rw-r--r--components/script/dom/htmlscriptelement.rs21
1 files changed, 10 insertions, 11 deletions
diff --git a/components/script/dom/htmlscriptelement.rs b/components/script/dom/htmlscriptelement.rs
index 2ece018c352..442f3063524 100644
--- a/components/script/dom/htmlscriptelement.rs
+++ b/components/script/dom/htmlscriptelement.rs
@@ -428,7 +428,7 @@ impl HTMLScriptElement {
}
let load = self.load.borrow_mut().take().unwrap();
- let (source, external, url) = match load {
+ let script = match load {
// Step 2.
Err(e) => {
warn!("error loading script {:?}", e);
@@ -436,14 +436,13 @@ impl HTMLScriptElement {
return;
}
- Ok(ScriptOrigin { text, url, external }) => {
- if external {
- debug!("loading external script, url = {}", url);
- }
- (text, external, url)
- },
+ Ok(script) => script,
};
+ if script.external {
+ debug!("loading external script, url = {}", script.url);
+ }
+
// TODO(#12446): beforescriptexecute.
if !self.dispatch_before_script_execute_event() {
return;
@@ -465,9 +464,9 @@ impl HTMLScriptElement {
// Step 5.a.2.
let window = window_from_node(self);
rooted!(in(window.get_cx()) let mut rval = UndefinedValue());
- window.evaluate_script_on_global_with_result(&*source,
- url.as_str(),
- rval.handle_mut());
+ window.evaluate_script_on_global_with_result(&script.text,
+ script.url.as_str(),
+ rval.handle_mut());
// Step 6.
document.set_current_script(old_script.r());
@@ -480,7 +479,7 @@ impl HTMLScriptElement {
self.dispatch_after_script_execute_event();
// Step 8.
- if external {
+ if script.external {
self.dispatch_load_event();
} else {
window.dom_manipulation_task_source().queue_simple_event(self.upcast(), atom!("load"), window.r());