diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2020-01-25 11:15:32 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-01-25 11:15:32 -0500 |
commit | 937efba0cd6662b4e0060e7056c52dac2896535c (patch) | |
tree | 0a29e3008fd7effae209944db3bebb8763732d82 /components/script/dom/htmlmenuelement.rs | |
parent | f3e6351e472bdbc3b574a7734437c9f8cd1b60cc (diff) | |
parent | c1a23a85b2a4f0e53d2d58de64adfee4be7fb30b (diff) | |
download | servo-937efba0cd6662b4e0060e7056c52dac2896535c.tar.gz servo-937efba0cd6662b4e0060e7056c52dac2896535c.zip |
Auto merge of #25576 - pshaughn:menuelement, r=jdm
Implement HTMLMenuElement
<!-- Please describe your changes on the following line: -->
Per spec, "The menu element is simply a semantic alternative to ul to express an unordered list of commands (a "toolbar")." We already have the CSS for it in user-agent.css, and this gives us the interface object.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes fix #24990
<!-- Either: -->
- [X] There are tests for these changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/htmlmenuelement.rs')
-rw-r--r-- | components/script/dom/htmlmenuelement.rs | 54 |
1 files changed, 54 insertions, 0 deletions
diff --git a/components/script/dom/htmlmenuelement.rs b/components/script/dom/htmlmenuelement.rs new file mode 100644 index 00000000000..b1b9955130c --- /dev/null +++ b/components/script/dom/htmlmenuelement.rs @@ -0,0 +1,54 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ + +use crate::dom::bindings::codegen::Bindings::HTMLMenuElementBinding; +use crate::dom::bindings::codegen::Bindings::HTMLMenuElementBinding::HTMLMenuElementMethods; +use crate::dom::bindings::root::DomRoot; +use crate::dom::document::Document; +use crate::dom::htmlelement::HTMLElement; +use crate::dom::node::Node; +use dom_struct::dom_struct; +use html5ever::{LocalName, Prefix}; + +#[dom_struct] +pub struct HTMLMenuElement { + htmlelement: HTMLElement, +} + +impl HTMLMenuElement { + fn new_inherited( + local_name: LocalName, + prefix: Option<Prefix>, + document: &Document, + ) -> HTMLMenuElement { + HTMLMenuElement { + htmlelement: HTMLElement::new_inherited(local_name, prefix, document), + } + } + + #[allow(unrooted_must_root)] + pub fn new( + local_name: LocalName, + prefix: Option<Prefix>, + document: &Document, + ) -> DomRoot<HTMLMenuElement> { + Node::reflect_node( + Box::new(HTMLMenuElement::new_inherited(local_name, prefix, document)), + document, + HTMLMenuElementBinding::Wrap, + ) + } +} + +impl HTMLMenuElementMethods for HTMLMenuElement { + // spec just mandates that compact reflects the content attribute, + // with no other semantics. Layout could use it to + // change line spacing, but nothing requires it to do so. + + // https://html.spec.whatwg.org/multipage/#dom-menu-compact + make_bool_setter!(SetCompact, "compact"); + + // https://html.spec.whatwg.org/multipage/#dom-menu-compact + make_bool_getter!(Compact, "compact"); +} |