aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/htmlmediaelement.rs
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2019-04-29 12:20:43 -0400
committerGitHub <noreply@github.com>2019-04-29 12:20:43 -0400
commit67beaa46e2015643e76becf18f415430ecb382bf (patch)
tree4565ec00838ae108166807923955512a42a89aec /components/script/dom/htmlmediaelement.rs
parenta9f7b132303f7c02648043df5ebdc25726bd3f88 (diff)
parent4383f4de487a6efd49745a568ce27435862e868d (diff)
downloadservo-67beaa46e2015643e76becf18f415430ecb382bf.tar.gz
servo-67beaa46e2015643e76becf18f415430ecb382bf.zip
Auto merge of #23236 - swarnimarun:loop_patch, r=ferjm
Implement HTMLMediaElement.loop Attribute <!-- Please describe your changes on the following line: --> Work done for Implementing HTMLMediaElement.loop Attribute, - Uncomment `loop` attribute from webidl - Add make_bool macros for Loop and SetLoop functions - Update the required tests --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22290 <!-- Either: --> - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23236) <!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/htmlmediaelement.rs')
-rw-r--r--components/script/dom/htmlmediaelement.rs11
1 files changed, 5 insertions, 6 deletions
diff --git a/components/script/dom/htmlmediaelement.rs b/components/script/dom/htmlmediaelement.rs
index 74c7c7ade62..066c53484e6 100644
--- a/components/script/dom/htmlmediaelement.rs
+++ b/components/script/dom/htmlmediaelement.rs
@@ -1548,17 +1548,11 @@ enum PlaybackDirection {
// XXX Placeholder implementations for:
//
// - https://github.com/servo/servo/issues/22293
-// - https://github.com/servo/servo/issues/22321
impl HTMLMediaElement {
// https://github.com/servo/servo/issues/22293
fn direction_of_playback(&self) -> PlaybackDirection {
PlaybackDirection::Forwards
}
-
- // https://github.com/servo/servo/pull/22321
- fn Loop(&self) -> bool {
- false
- }
}
impl Drop for HTMLMediaElement {
@@ -1587,6 +1581,11 @@ impl HTMLMediaElementMethods for HTMLMediaElement {
// https://html.spec.whatwg.org/multipage/#dom-media-autoplay
make_bool_setter!(SetAutoplay, "autoplay");
+ // https://html.spec.whatwg.org/multipage/#attr-media-loop
+ make_bool_getter!(Loop, "loop");
+ // https://html.spec.whatwg.org/multipage/#attr-media-loop
+ make_bool_setter!(SetLoop, "loop");
+
// https://html.spec.whatwg.org/multipage/#dom-media-defaultmuted
make_bool_getter!(DefaultMuted, "muted");
// https://html.spec.whatwg.org/multipage/#dom-media-defaultmuted