diff options
author | Cameron Zwarich <zwarich@mozilla.com> | 2014-09-18 13:43:15 -0700 |
---|---|---|
committer | Cameron Zwarich <zwarich@mozilla.com> | 2014-09-19 13:39:17 -0700 |
commit | 4fa872511117eafd934cad70c7d3b8c583fb960e (patch) | |
tree | 8c75e871c896648de54c2e9aa376d30b4b98220e /components/script/dom/htmlimageelement.rs | |
parent | b8f34bbc5170f78e4939b1d647f8d8498e3c2fb6 (diff) | |
download | servo-4fa872511117eafd934cad70c7d3b8c583fb960e.tar.gz servo-4fa872511117eafd934cad70c7d3b8c583fb960e.zip |
First steps of &JSRef -> JSRef conversion
Replace &JSRef with JSRef in the bulk of the generated code. This will
remove a level of indirection throughout all DOM code.
This patch doesn't change methods implemented on JSRef<T> to take `self`
rather than `&self`, and it leaves a few other uses of &JSRef, but those
changes can be made incrementally.
Diffstat (limited to 'components/script/dom/htmlimageelement.rs')
-rw-r--r-- | components/script/dom/htmlimageelement.rs | 38 |
1 files changed, 19 insertions, 19 deletions
diff --git a/components/script/dom/htmlimageelement.rs b/components/script/dom/htmlimageelement.rs index 903e52bb309..f534182a53c 100644 --- a/components/script/dom/htmlimageelement.rs +++ b/components/script/dom/htmlimageelement.rs @@ -46,7 +46,7 @@ impl<'a> PrivateHTMLImageElementHelpers for JSRef<'a, HTMLImageElement> { /// Makes the local `image` member match the status of the `src` attribute and starts /// prefetching the image. This method must be called after `src` is changed. fn update_image(&self, value: Option<(DOMString, &Url)>) { - let node: &JSRef<Node> = NodeCast::from_ref(self); + let node: JSRef<Node> = NodeCast::from_ref(*self); let document = node.owner_doc().root(); let window = document.deref().window.root(); let image_cache = &window.image_cache_task; @@ -72,7 +72,7 @@ impl<'a> PrivateHTMLImageElementHelpers for JSRef<'a, HTMLImageElement> { } impl HTMLImageElement { - pub fn new_inherited(localName: DOMString, document: &JSRef<Document>) -> HTMLImageElement { + pub fn new_inherited(localName: DOMString, document: JSRef<Document>) -> HTMLImageElement { HTMLImageElement { htmlelement: HTMLElement::new_inherited(HTMLImageElementTypeId, localName, document), image: Untraceable::new(RefCell::new(None)), @@ -80,7 +80,7 @@ impl HTMLImageElement { } #[allow(unrooted_must_root)] - pub fn new(localName: DOMString, document: &JSRef<Document>) -> Temporary<HTMLImageElement> { + pub fn new(localName: DOMString, document: JSRef<Document>) -> Temporary<HTMLImageElement> { let element = HTMLImageElement::new_inherited(localName, document); Node::reflect_node(box element, document, HTMLImageElementBinding::Wrap) } @@ -100,99 +100,99 @@ impl<'a> HTMLImageElementMethods for JSRef<'a, HTMLImageElement> { make_getter!(Alt) fn SetAlt(&self, alt: DOMString) { - let element: &JSRef<Element> = ElementCast::from_ref(self); + let element: JSRef<Element> = ElementCast::from_ref(*self); element.set_string_attribute("alt", alt) } make_getter!(Src) fn SetSrc(&self, src: DOMString) { - let element: &JSRef<Element> = ElementCast::from_ref(self); + let element: JSRef<Element> = ElementCast::from_ref(*self); element.set_url_attribute("src", src) } make_getter!(UseMap) fn SetUseMap(&self, use_map: DOMString) { - let element: &JSRef<Element> = ElementCast::from_ref(self); + let element: JSRef<Element> = ElementCast::from_ref(*self); element.set_string_attribute("usemap", use_map) } make_bool_getter!(IsMap) fn SetIsMap(&self, is_map: bool) { - let element: &JSRef<Element> = ElementCast::from_ref(self); + let element: JSRef<Element> = ElementCast::from_ref(*self); element.set_string_attribute("ismap", is_map.to_string()) } fn Width(&self) -> u32 { - let node: &JSRef<Node> = NodeCast::from_ref(self); + let node: JSRef<Node> = NodeCast::from_ref(*self); let rect = node.get_bounding_content_box(); to_px(rect.size.width) as u32 } fn SetWidth(&self, width: u32) { - let elem: &JSRef<Element> = ElementCast::from_ref(self); + let elem: JSRef<Element> = ElementCast::from_ref(*self); elem.set_uint_attribute("width", width) } fn Height(&self) -> u32 { - let node: &JSRef<Node> = NodeCast::from_ref(self); + let node: JSRef<Node> = NodeCast::from_ref(*self); let rect = node.get_bounding_content_box(); to_px(rect.size.height) as u32 } fn SetHeight(&self, height: u32) { - let elem: &JSRef<Element> = ElementCast::from_ref(self); + let elem: JSRef<Element> = ElementCast::from_ref(*self); elem.set_uint_attribute("height", height) } make_getter!(Name) fn SetName(&self, name: DOMString) { - let element: &JSRef<Element> = ElementCast::from_ref(self); + let element: JSRef<Element> = ElementCast::from_ref(*self); element.set_string_attribute("name", name) } make_getter!(Align) fn SetAlign(&self, align: DOMString) { - let element: &JSRef<Element> = ElementCast::from_ref(self); + let element: JSRef<Element> = ElementCast::from_ref(*self); element.set_string_attribute("align", align) } make_uint_getter!(Hspace) fn SetHspace(&self, hspace: u32) { - let element: &JSRef<Element> = ElementCast::from_ref(self); + let element: JSRef<Element> = ElementCast::from_ref(*self); element.set_uint_attribute("hspace", hspace) } make_uint_getter!(Vspace) fn SetVspace(&self, vspace: u32) { - let element: &JSRef<Element> = ElementCast::from_ref(self); + let element: JSRef<Element> = ElementCast::from_ref(*self); element.set_uint_attribute("vspace", vspace) } make_getter!(LongDesc) fn SetLongDesc(&self, longdesc: DOMString) { - let element: &JSRef<Element> = ElementCast::from_ref(self); + let element: JSRef<Element> = ElementCast::from_ref(*self); element.set_string_attribute("longdesc", longdesc) } make_getter!(Border) fn SetBorder(&self, border: DOMString) { - let element: &JSRef<Element> = ElementCast::from_ref(self); + let element: JSRef<Element> = ElementCast::from_ref(*self); element.set_string_attribute("border", border) } } impl<'a> VirtualMethods for JSRef<'a, HTMLImageElement> { fn super_type<'a>(&'a self) -> Option<&'a VirtualMethods> { - let htmlelement: &JSRef<HTMLElement> = HTMLElementCast::from_ref(self); + let htmlelement: &JSRef<HTMLElement> = HTMLElementCast::from_borrowed_ref(self); Some(htmlelement as &VirtualMethods) } @@ -203,7 +203,7 @@ impl<'a> VirtualMethods for JSRef<'a, HTMLImageElement> { } if "src" == name.as_slice() { - let window = window_from_node(self).root(); + let window = window_from_node(*self).root(); let url = window.deref().get_url(); self.update_image(Some((value, &url))); } |