aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/htmlimageelement.rs
diff options
context:
space:
mode:
authorbors-servo <metajack+bors@gmail.com>2015-08-27 09:38:48 -0600
committerbors-servo <metajack+bors@gmail.com>2015-08-27 09:38:48 -0600
commit909429702972d53bf02dfe9a4aa93ea0cb588cf4 (patch)
tree1a64c15ec378b98ae445257c1c7177af65afee6b /components/script/dom/htmlimageelement.rs
parent2d704312685249c20fa71d983094fc4e689bc5ff (diff)
parent2a028f66a2e7ab56094cf856ebdc20bc49ab7d4d (diff)
downloadservo-909429702972d53bf02dfe9a4aa93ea0cb588cf4.tar.gz
servo-909429702972d53bf02dfe9a4aa93ea0cb588cf4.zip
Auto merge of #7401 - nox:rm-helpers, r=Manishearth
Remove helper traits Now that `JSRef<T>` is gone, there is no need to have helper traits. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7401) <!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/htmlimageelement.rs')
-rw-r--r--components/script/dom/htmlimageelement.rs24
1 files changed, 8 insertions, 16 deletions
diff --git a/components/script/dom/htmlimageelement.rs b/components/script/dom/htmlimageelement.rs
index f60817e8592..bfd13057f25 100644
--- a/components/script/dom/htmlimageelement.rs
+++ b/components/script/dom/htmlimageelement.rs
@@ -3,7 +3,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
use dom::attr::Attr;
-use dom::attr::{AttrHelpers, AttrValue};
+use dom::attr::AttrValue;
use dom::bindings::cell::DOMRefCell;
use dom::bindings::codegen::Bindings::HTMLImageElementBinding;
use dom::bindings::codegen::Bindings::HTMLImageElementBinding::HTMLImageElementMethods;
@@ -14,15 +14,13 @@ use dom::bindings::error::Fallible;
use dom::bindings::global::GlobalRef;
use dom::bindings::js::{LayoutJS, Root};
use dom::bindings::refcounted::Trusted;
-use dom::document::{Document, DocumentHelpers};
-use dom::element::AttributeHandlers;
+use dom::document::Document;
use dom::element::ElementTypeId;
-use dom::event::{Event, EventBubbles, EventCancelable, EventHelpers};
+use dom::event::{Event, EventBubbles, EventCancelable};
use dom::eventtarget::{EventTarget, EventTargetTypeId};
use dom::htmlelement::{HTMLElement, HTMLElementTypeId};
-use dom::node::{document_from_node, Node, NodeTypeId, NodeHelpers, NodeDamage, window_from_node};
+use dom::node::{document_from_node, Node, NodeTypeId, NodeDamage, window_from_node};
use dom::virtualmethods::VirtualMethods;
-use dom::window::WindowHelpers;
use script_task::{Runnable, ScriptChan, CommonScriptMsg};
use string_cache::Atom;
use util::str::DOMString;
@@ -51,19 +49,13 @@ impl HTMLImageElementDerived for EventTarget {
}
}
-pub trait HTMLImageElementHelpers {
- fn get_url(&self) -> Option<Url>;
-}
-impl<'a> HTMLImageElementHelpers for &'a HTMLImageElement {
- fn get_url(&self) -> Option<Url>{
+impl HTMLImageElement {
+ pub fn get_url(&self) -> Option<Url>{
self.url.borrow().clone()
}
}
-trait PrivateHTMLImageElementHelpers {
- fn update_image(self, value: Option<(DOMString, &Url)>);
-}
struct ImageResponseHandlerRunnable {
element: Trusted<HTMLImageElement>,
@@ -112,10 +104,10 @@ impl Runnable for ImageResponseHandlerRunnable {
}
}
-impl<'a> PrivateHTMLImageElementHelpers for &'a HTMLImageElement {
+impl HTMLImageElement {
/// Makes the local `image` member match the status of the `src` attribute and starts
/// prefetching the image. This method must be called after `src` is changed.
- fn update_image(self, value: Option<(DOMString, &Url)>) {
+ fn update_image(&self, value: Option<(DOMString, &Url)>) {
let node = NodeCast::from_ref(self);
let document = node.owner_doc();
let window = document.r().window();