diff options
| author | Martin Robinson <mrobinson@igalia.com> | 2024-04-03 10:41:19 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-03 08:41:19 +0000 |
| commit | 18b37e676bcd50f754cd189444080fc547c9d48a (patch) | |
| tree | ca2e235d13b6f9b19cff9172810b0c6f08265f3b /components/script/dom/htmliframeelement.rs | |
| parent | 8aaff613342568c13e9141758b770788694d2f84 (diff) | |
| download | servo-18b37e676bcd50f754cd189444080fc547c9d48a.tar.gz servo-18b37e676bcd50f754cd189444080fc547c9d48a.zip | |
script: Reduce the use of `unsafe` in LayoutDom (#31979)
Remove the use of unsafe code in the layout wrappers of the DOM. The
main change here is that `unsafe_get()` no longer needs to be an unsafe
method, which allows us to transitively remove or reduce unsafe blocks
from callers. The function itself is not renamed, because it's still
a bit dangerous to start removing the layers of abstraction from actual
DOM nodes.
In addition `init_style_and_opaque_layout_data` can be merged into
`initialize_data`, which removes one more unsafe method.
Finally, a "Safety" section is added to some unsafe methods.
Diffstat (limited to 'components/script/dom/htmliframeelement.rs')
| -rw-r--r-- | components/script/dom/htmliframeelement.rs | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/components/script/dom/htmliframeelement.rs b/components/script/dom/htmliframeelement.rs index 23613c9f1ba..6d2cd80689a 100644 --- a/components/script/dom/htmliframeelement.rs +++ b/components/script/dom/htmliframeelement.rs @@ -515,15 +515,13 @@ pub trait HTMLIFrameElementLayoutMethods { impl HTMLIFrameElementLayoutMethods for LayoutDom<'_, HTMLIFrameElement> { #[inline] - #[allow(unsafe_code)] fn pipeline_id(self) -> Option<PipelineId> { - unsafe { (self.unsafe_get()).pipeline_id.get() } + (self.unsafe_get()).pipeline_id.get() } #[inline] - #[allow(unsafe_code)] fn browsing_context_id(self) -> Option<BrowsingContextId> { - unsafe { (self.unsafe_get()).browsing_context_id.get() } + (self.unsafe_get()).browsing_context_id.get() } fn get_width(self) -> LengthOrPercentageOrAuto { |