diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2018-12-22 23:50:40 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-12-22 23:50:40 -0500 |
| commit | 27577955aa1c61a91809389a07846f0259a0a939 (patch) | |
| tree | ee3fb25a46e9168135089ca4dd9b791d8bc6a5f5 /components/script/dom/htmliframeelement.rs | |
| parent | 47eb8fe3dbab5dcb02c20c9a7c10f971f6fa7566 (diff) | |
| parent | c46508e497e503c8fd42deb26aa536060334a9c9 (diff) | |
| download | servo-27577955aa1c61a91809389a07846f0259a0a939.tar.gz servo-27577955aa1c61a91809389a07846f0259a0a939.zip | |
Auto merge of #22456 - dlrobertson:fix_src, r=ferjm
Update src/href attributes to be a USVString
The following IDLs have the src/href attributes typed as a `DOMString`
while in the spec the attribute has been updated to be a `USVString`:
- [HTMLIFrameElement]
- [HTMLImageElement]
- [HTMLInputElement]
- [HTMLLinkElement]
- [HTMLMediaElement]
- [HTMLScriptElement]
Fixes: #22454
[HTMLIFrameElement]: https://html.spec.whatwg.org/multipage/#htmliframeelement
[HTMLImageElement]: https://html.spec.whatwg.org/multipage/#htmlimageelement
[HTMLInputElement]: https://html.spec.whatwg.org/multipage/#htmlinputelement
[HTMLLinkElement]: https://html.spec.whatwg.org/multipage/#htmllinkelement
[HTMLMediaElement]: https://html.spec.whatwg.org/multipage/#htmlmediaelement
[HTMLScriptElement]: https://html.spec.whatwg.org/multipage/#htmlscriptelement
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22456)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/htmliframeelement.rs')
| -rw-r--r-- | components/script/dom/htmliframeelement.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/components/script/dom/htmliframeelement.rs b/components/script/dom/htmliframeelement.rs index e471e78aeaf..288584932f0 100644 --- a/components/script/dom/htmliframeelement.rs +++ b/components/script/dom/htmliframeelement.rs @@ -12,7 +12,7 @@ use crate::dom::bindings::inheritance::Castable; use crate::dom::bindings::refcounted::Trusted; use crate::dom::bindings::reflector::DomObject; use crate::dom::bindings::root::{DomRoot, LayoutDom, MutNullableDom}; -use crate::dom::bindings::str::DOMString; +use crate::dom::bindings::str::{DOMString, USVString}; use crate::dom::document::Document; use crate::dom::domtokenlist::DOMTokenList; use crate::dom::element::{AttributeMutation, Element, RawLayoutElementHelpers}; @@ -481,7 +481,7 @@ impl HTMLIFrameElementMethods for HTMLIFrameElement { make_url_getter!(Src, "src"); // https://html.spec.whatwg.org/multipage/#dom-iframe-src - make_setter!(SetSrc, "src"); + make_url_setter!(SetSrc, "src"); // https://html.spec.whatwg.org/multipage/#dom-iframe-sandbox fn Sandbox(&self) -> DomRoot<DOMTokenList> { |