diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-02-13 13:31:33 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-02-13 13:31:33 -0800 |
| commit | da8d15427cbe82dabb3ce48580738b775c9086d0 (patch) | |
| tree | a1a5f217f4bcc3ae48bbc8b0ebc7f1fafdb568b5 /components/script/dom/htmlfontelement.rs | |
| parent | 28d62f0f031a389463bf2afd1cfbd53da96a5068 (diff) | |
| parent | 7409031af2a066386c18c8813f80f7fd539fb6be (diff) | |
| download | servo-da8d15427cbe82dabb3ce48580738b775c9086d0.tar.gz servo-da8d15427cbe82dabb3ce48580738b775c9086d0.zip | |
Auto merge of #15527 - simon-whitehead:fix-15521, r=cbrewster
Make HTMLOptionsCollection constructor accept a HTMLSelectElement argument. Fixes #15521
<!-- Please describe your changes on the following line: -->
Moves the `HTMLSelectElement.upcast()` call into the `HTMLOptionsCollection` constructors, replacing their signatures with `&HTMLSelectElement` references. This limits the surface area for misuse by only allowing `HTMLSelectElement` instances to be passed in rather than `Node` instances.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15521.
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because: the linked issue explicitly says building without errors is good enough.
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15527)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/htmlfontelement.rs')
0 files changed, 0 insertions, 0 deletions