diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2020-01-20 11:44:56 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-01-20 11:44:56 -0500 |
commit | f2d096fa6a0eef7f7f8e299a6b430b5a5a27d0c1 (patch) | |
tree | 0e6a773784580991ca01b9b893707bbde792648b /components/script/dom/htmldialogelement.rs | |
parent | 0b79fe377d9a851e06c48449f43db81acdd56caa (diff) | |
parent | 6fa50a423e2e5cf01c1a178eede93f79319682f3 (diff) | |
download | servo-f2d096fa6a0eef7f7f8e299a6b430b5a5a27d0c1.tar.gz servo-f2d096fa6a0eef7f7f8e299a6b430b5a5a27d0c1.zip |
Auto merge of #25555 - warren-fisher:fix-mach-all, r=jdm
Add default arguments so that ./mach test --all works
<!-- Please describe your changes on the following line: -->
Fix `./mach test --all` not getting any default values for `force_cpp` and `no_wpt` in [python/servo/testing_commands.py](https://github.com/servo/servo/blob/2a594821ba44ba2c13e9a39c6fd8c5a450bd06f4/python/servo/testing_commands.py#L319-L334). For `./mach test-tidy` the default values are obtained using the `@CommandArgument` decorator, but this does not apply for calling `test_tidy()` when using `./mach test --all` (which calls the function directly). This call is found on line 109 of `registrar.py` which should be located in something like `python/_virtualenv2.7/python2.7/site-packages/mach/registrar.py` (but not located in this git repository).
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25554 (GitHub issue number if applicable)
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because the change is minimal and non breaking. Any existing code should be able to work if it uses keyword arguments because the default values will be overriden. If there is code that calls `test_tidy()` with arguments by position this would cause breakage, but I do not believe this happens anywhere in the `testing_command.py` file. `./mach test-tidy` should still work because the arguments are set using the `@CommandArgument` decorator.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/htmldialogelement.rs')
0 files changed, 0 insertions, 0 deletions