diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2020-01-21 12:38:07 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-01-21 12:38:07 -0500 |
commit | 0c4205ebfe3ab2c78b0318371858225021d4cb06 (patch) | |
tree | f9521e7a56b85dfb6c537206fcc9679e439285ca /components/script/dom/htmlaudioelement.rs | |
parent | 52ac5316addefad94ebf919d1a8f0db6757a3f3d (diff) | |
parent | 6e296150f84f84c3679ea89d7b9f2c8e6325b242 (diff) | |
download | servo-0c4205ebfe3ab2c78b0318371858225021d4cb06.tar.gz servo-0c4205ebfe3ab2c78b0318371858225021d4cb06.zip |
Auto merge of #25431 - warren-fisher:create-html-element, r=jdm
use create_html_element for HTMLAudioElement and HTMLImageElement
<!-- Please describe your changes on the following line: -->
Updated the Image and Audio constructors to use `create_html_element` via the Element::create method. This was done to meet these specifications of "Let (audio/image) be the result of **creating an element** given document, audio, and the HTML namespace." for [dom-image](https://html.spec.whatwg.org/multipage/embedded-content.html#dom-image) and [dom-audio](https://html.spec.whatwg.org/multipage/media.html#dom-audio)
Not sure what _is_ is according to the [create-element guidelines](https://dom.spec.whatwg.org/#concept-create-element) so I left it as None copying from #25393. Also copied the ElementCreator and CustomElementCreationMode from #25393 as I do not know what they do.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25421 (GitHub issue number if applicable)
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it is a small swap out of the way used to generate these HTML elements. The pre-existing tests should be sufficient.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/htmlaudioelement.rs')
-rw-r--r-- | components/script/dom/htmlaudioelement.rs | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/components/script/dom/htmlaudioelement.rs b/components/script/dom/htmlaudioelement.rs index 1a8472cf8ee..aa18834e631 100644 --- a/components/script/dom/htmlaudioelement.rs +++ b/components/script/dom/htmlaudioelement.rs @@ -10,12 +10,12 @@ use crate::dom::bindings::inheritance::Castable; use crate::dom::bindings::root::DomRoot; use crate::dom::bindings::str::DOMString; use crate::dom::document::Document; -use crate::dom::element::Element; +use crate::dom::element::{CustomElementCreationMode, Element, ElementCreator}; use crate::dom::htmlmediaelement::HTMLMediaElement; use crate::dom::node::Node; use crate::dom::window::Window; use dom_struct::dom_struct; -use html5ever::{LocalName, Prefix}; +use html5ever::{LocalName, Prefix, QualName}; #[dom_struct] pub struct HTMLAudioElement { @@ -51,8 +51,15 @@ impl HTMLAudioElement { // https://html.spec.whatwg.org/multipage/#dom-audio #[allow(non_snake_case)] pub fn Audio(window: &Window, src: Option<DOMString>) -> Fallible<DomRoot<HTMLAudioElement>> { - let document = window.Document(); - let audio = HTMLAudioElement::new(local_name!("audio"), None, &document); + let element = Element::create( + QualName::new(None, ns!(html), local_name!("audio")), + None, + &window.Document(), + ElementCreator::ScriptCreated, + CustomElementCreationMode::Synchronous, + ); + + let audio = DomRoot::downcast::<HTMLAudioElement>(element).unwrap(); audio .upcast::<Element>() |