diff options
author | Josh Matthews <josh@joshmatthews.net> | 2024-08-22 07:42:36 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-08-22 11:42:36 +0000 |
commit | 60ef6bc46125d34e492a4294622e2791f3c619b5 (patch) | |
tree | 8bc8a90f3a4647a7d6565065a8d73bd1b8f29d3d /components/script/dom/headers.rs | |
parent | 9a1051c9170abc8e40c43b2a6be712a3ff4b523f (diff) | |
download | servo-60ef6bc46125d34e492a4294622e2791f3c619b5.tar.gz servo-60ef6bc46125d34e492a4294622e2791f3c619b5.zip |
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Propagate CanGc from reflect_dom_object_with_proto.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Mark DOM constructors as GC operations.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/headers.rs')
-rw-r--r-- | components/script/dom/headers.rs | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/components/script/dom/headers.rs b/components/script/dom/headers.rs index 7d18913533c..7bf032693ee 100644 --- a/components/script/dom/headers.rs +++ b/components/script/dom/headers.rs @@ -20,6 +20,7 @@ use crate::dom::bindings::reflector::{reflect_dom_object_with_proto, Reflector}; use crate::dom::bindings::root::DomRoot; use crate::dom::bindings::str::{is_token, ByteString}; use crate::dom::globalscope::GlobalScope; +use crate::script_runtime::CanGc; #[dom_struct] pub struct Headers { @@ -50,11 +51,15 @@ impl Headers { } pub fn new(global: &GlobalScope) -> DomRoot<Headers> { - Self::new_with_proto(global, None) + Self::new_with_proto(global, None, CanGc::note()) } - fn new_with_proto(global: &GlobalScope, proto: Option<HandleObject>) -> DomRoot<Headers> { - reflect_dom_object_with_proto(Box::new(Headers::new_inherited()), global, proto) + fn new_with_proto( + global: &GlobalScope, + proto: Option<HandleObject>, + can_gc: CanGc, + ) -> DomRoot<Headers> { + reflect_dom_object_with_proto(Box::new(Headers::new_inherited()), global, proto, can_gc) } // https://fetch.spec.whatwg.org/#dom-headers @@ -62,9 +67,10 @@ impl Headers { pub fn Constructor( global: &GlobalScope, proto: Option<HandleObject>, + can_gc: CanGc, init: Option<HeadersInit>, ) -> Fallible<DomRoot<Headers>> { - let dom_headers_new = Headers::new_with_proto(global, proto); + let dom_headers_new = Headers::new_with_proto(global, proto, can_gc); dom_headers_new.fill(init)?; Ok(dom_headers_new) } |