diff options
| author | Josh Matthews <josh@joshmatthews.net> | 2024-08-22 07:42:36 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-22 11:42:36 +0000 |
| commit | 60ef6bc46125d34e492a4294622e2791f3c619b5 (patch) | |
| tree | 8bc8a90f3a4647a7d6565065a8d73bd1b8f29d3d /components/script/dom/gpuerror.rs | |
| parent | 9a1051c9170abc8e40c43b2a6be712a3ff4b523f (diff) | |
| download | servo-60ef6bc46125d34e492a4294622e2791f3c619b5.tar.gz servo-60ef6bc46125d34e492a4294622e2791f3c619b5.zip | |
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Propagate CanGc from reflect_dom_object_with_proto.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Mark DOM constructors as GC operations.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/gpuerror.rs')
| -rw-r--r-- | components/script/dom/gpuerror.rs | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/components/script/dom/gpuerror.rs b/components/script/dom/gpuerror.rs index a79a6d85ed8..c50ac96ed83 100644 --- a/components/script/dom/gpuerror.rs +++ b/components/script/dom/gpuerror.rs @@ -12,6 +12,7 @@ use crate::dom::bindings::reflector::{reflect_dom_object_with_proto, Reflector}; use crate::dom::bindings::root::DomRoot; use crate::dom::bindings::str::DOMString; use crate::dom::globalscope::GlobalScope; +use crate::script_runtime::CanGc; #[dom_struct] pub struct GPUError { @@ -38,7 +39,12 @@ impl GPUError { proto: Option<HandleObject>, message: DOMString, ) -> DomRoot<Self> { - reflect_dom_object_with_proto(Box::new(GPUError::new_inherited(message)), global, proto) + reflect_dom_object_with_proto( + Box::new(GPUError::new_inherited(message)), + global, + proto, + CanGc::note(), + ) } pub fn from_error(global: &GlobalScope, error: Error) -> DomRoot<Self> { @@ -47,16 +53,19 @@ impl GPUError { global, None, DOMString::from_string(msg), + CanGc::note(), )), Error::OutOfMemory(msg) => DomRoot::upcast(GPUOutOfMemoryError::new_with_proto( global, None, DOMString::from_string(msg), + CanGc::note(), )), Error::Internal(msg) => DomRoot::upcast(GPUInternalError::new_with_proto( global, None, DOMString::from_string(msg), + CanGc::note(), )), } } |