diff options
| author | Josh Matthews <josh@joshmatthews.net> | 2024-11-05 03:29:08 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-05 08:29:08 +0000 |
| commit | 25a0764a37a585d032ca352923b24995f8cbf1a0 (patch) | |
| tree | 1805edc4fc79396de9150f8bc063888926d53d3b /components/script/dom/gamepadhapticactuator.rs | |
| parent | 537958a3ccb57502c558e4da0963307fd7481a14 (diff) | |
| download | servo-25a0764a37a585d032ca352923b24995f8cbf1a0.tar.gz servo-25a0764a37a585d032ca352923b24995f8cbf1a0.zip | |
Use out parameter for generated methods returning JSVal (#34087)
* Make generated bindings that return a WebIDL `any` value use out parameters.
Returning raw JSVal values makes it easier to create GC hazards in code
that calls these methods. Accepting a MutableHandle argument instead
ensures that the values are rooted by the caller.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Update mozjs.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Fix clippy warnings.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/gamepadhapticactuator.rs')
| -rw-r--r-- | components/script/dom/gamepadhapticactuator.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/components/script/dom/gamepadhapticactuator.rs b/components/script/dom/gamepadhapticactuator.rs index 3f7513b29ce..10be49dcfee 100644 --- a/components/script/dom/gamepadhapticactuator.rs +++ b/components/script/dom/gamepadhapticactuator.rs @@ -9,7 +9,7 @@ use dom_struct::dom_struct; use embedder_traits::{DualRumbleEffectParams, EmbedderMsg}; use ipc_channel::ipc; use ipc_channel::router::ROUTER; -use js::jsval::JSVal; +use js::rust::MutableHandleValue; use script_traits::GamepadSupportedHapticEffects; use crate::dom::bindings::cell::DomRefCell; @@ -134,8 +134,8 @@ impl GamepadHapticActuator { impl GamepadHapticActuatorMethods for GamepadHapticActuator { /// <https://www.w3.org/TR/gamepad/#dom-gamepadhapticactuator-effects> - fn Effects(&self, cx: JSContext) -> JSVal { - to_frozen_array(self.effects.as_slice(), cx) + fn Effects(&self, cx: JSContext, retval: MutableHandleValue) { + to_frozen_array(self.effects.as_slice(), cx, retval) } /// <https://www.w3.org/TR/gamepad/#dom-gamepadhapticactuator-playeffect> |