diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2018-03-23 15:15:38 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-03-23 15:15:38 -0400 |
commit | e8fdc677f440919507209ed42d0ea042c700042c (patch) | |
tree | fab6934483c93cf67273458bd193c75e3f3a7d64 /components/script/dom/gamepadbuttonlist.rs | |
parent | 18ef5874dd3e11551e2f9503746540847eeb974c (diff) | |
parent | 80c6891f339c52778ee7133b3b3f8ae9c8c350e5 (diff) | |
download | servo-e8fdc677f440919507209ed42d0ea042c700042c.tar.gz servo-e8fdc677f440919507209ed42d0ea042c700042c.zip |
Auto merge of #20396 - Xanewok:webgl-typed-arrays, r=jdm
Replace `object` function arguments in WebGL with typed arrays
<!-- Please describe your changes on the following line: -->
Could use a https://github.com/servo/rust-mozjs/pull/402 in some places, as this should simplify a little bit and remove unnecessary `#[allow(unsafe_code)]` attributes.
I sort of hacked my way through for https://github.com/servo/servo/issues/20394 since I encountered this issue as well. I agree that the comment above makes me feel uneasy about this and feels like I'm missing something and this shouldn't be the way we eventually resolve the overloads with auto rootable types (talking about this: https://github.com/servo/servo/pull/20396/files#diff-60d01595cff328c165842fea9e4ccbc2R428).
r? @jdm
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20342 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because if the bindings compile now, it works!
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20396)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/gamepadbuttonlist.rs')
0 files changed, 0 insertions, 0 deletions