aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/filereadersync.rs
diff options
context:
space:
mode:
authorJosh Matthews <josh@joshmatthews.net>2024-08-22 07:42:36 -0400
committerGitHub <noreply@github.com>2024-08-22 11:42:36 +0000
commit60ef6bc46125d34e492a4294622e2791f3c619b5 (patch)
tree8bc8a90f3a4647a7d6565065a8d73bd1b8f29d3d /components/script/dom/filereadersync.rs
parent9a1051c9170abc8e40c43b2a6be712a3ff4b523f (diff)
downloadservo-60ef6bc46125d34e492a4294622e2791f3c619b5.tar.gz
servo-60ef6bc46125d34e492a4294622e2791f3c619b5.zip
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Propagate CanGc from reflect_dom_object_with_proto. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Mark DOM constructors as GC operations. Signed-off-by: Josh Matthews <josh@joshmatthews.net> --------- Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/filereadersync.rs')
-rw-r--r--components/script/dom/filereadersync.rs18
1 files changed, 14 insertions, 4 deletions
diff --git a/components/script/dom/filereadersync.rs b/components/script/dom/filereadersync.rs
index 5a20f26f476..699f4003491 100644
--- a/components/script/dom/filereadersync.rs
+++ b/components/script/dom/filereadersync.rs
@@ -19,7 +19,7 @@ use crate::dom::bindings::str::DOMString;
use crate::dom::blob::Blob;
use crate::dom::filereader::FileReaderSharedFunctionality;
use crate::dom::globalscope::GlobalScope;
-use crate::script_runtime::JSContext;
+use crate::script_runtime::{CanGc, JSContext};
#[dom_struct]
pub struct FileReaderSync {
@@ -33,16 +33,26 @@ impl FileReaderSync {
}
}
- fn new(global: &GlobalScope, proto: Option<HandleObject>) -> DomRoot<FileReaderSync> {
- reflect_dom_object_with_proto(Box::new(FileReaderSync::new_inherited()), global, proto)
+ fn new(
+ global: &GlobalScope,
+ proto: Option<HandleObject>,
+ can_gc: CanGc,
+ ) -> DomRoot<FileReaderSync> {
+ reflect_dom_object_with_proto(
+ Box::new(FileReaderSync::new_inherited()),
+ global,
+ proto,
+ can_gc,
+ )
}
#[allow(non_snake_case)]
pub fn Constructor(
global: &GlobalScope,
proto: Option<HandleObject>,
+ can_gc: CanGc,
) -> Fallible<DomRoot<FileReaderSync>> {
- Ok(FileReaderSync::new(global, proto))
+ Ok(FileReaderSync::new(global, proto, can_gc))
}
fn get_blob_bytes(blob: &Blob) -> Result<Vec<u8>, Error> {