diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-06-09 14:31:48 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-06-09 14:31:48 -0700 |
commit | 061cb5f48e5c93a5decf39e530aea4a566e97341 (patch) | |
tree | 1682083740ce2a850c5204cd046918a8427c57ba /components/script/dom/element.rs | |
parent | 8fee7f45e0481bf6074788029f8a1eaea24fcca5 (diff) | |
parent | 27ae1ef2e7d78f38e744f2e00e177302f2d6aa82 (diff) | |
download | servo-061cb5f48e5c93a5decf39e530aea4a566e97341.tar.gz servo-061cb5f48e5c93a5decf39e530aea4a566e97341.zip |
Auto merge of #16752 - jdm:css-parse-error, r=SimonSapin
Report more informative CSS errors
This requires https://github.com/servo/rust-cssparser/pull/143 for the final commit. There's no better way to split that work up, unfortunately, and it's extremely easy to bitrot. I would appreciate if we could expedite reviewing this work.
This is the work necessary to enable https://bugzilla.mozilla.org/show_bug.cgi?id=1352669. It makes sense to merge it separately because it's so much effort to keep it up to date with the ongoing Stylo work.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16752)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/element.rs')
-rw-r--r-- | components/script/dom/element.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/components/script/dom/element.rs b/components/script/dom/element.rs index 189410ce77a..b4e7be3203a 100644 --- a/components/script/dom/element.rs +++ b/components/script/dom/element.rs @@ -2061,7 +2061,7 @@ impl ElementMethods for Element { // https://dom.spec.whatwg.org/#dom-element-matches fn Matches(&self, selectors: DOMString) -> Fallible<bool> { match SelectorParser::parse_author_origin_no_namespace(&selectors) { - Err(()) => Err(Error::Syntax), + Err(_) => Err(Error::Syntax), Ok(selectors) => { let mut ctx = MatchingContext::new(MatchingMode::Normal, None); Ok(matches_selector_list(&selectors, &Root::from_ref(self), &mut ctx)) @@ -2077,7 +2077,7 @@ impl ElementMethods for Element { // https://dom.spec.whatwg.org/#dom-element-closest fn Closest(&self, selectors: DOMString) -> Fallible<Option<Root<Element>>> { match SelectorParser::parse_author_origin_no_namespace(&selectors) { - Err(()) => Err(Error::Syntax), + Err(_) => Err(Error::Syntax), Ok(selectors) => { let root = self.upcast::<Node>(); for element in root.inclusive_ancestors() { |