diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-04-24 10:35:52 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-04-24 10:35:52 -0500 |
commit | ef3903163da57ef31ee0a2566b627c58473bdaab (patch) | |
tree | 28758ca95e671f5d99d2292cdf133ba561510e92 /components/script/dom/element.rs | |
parent | 4263b798ad3969ceeb86e607d5f13eeadd2db6dd (diff) | |
parent | 853c91781e921bcb7a0c539f970c2f6c4c9d3302 (diff) | |
download | servo-ef3903163da57ef31ee0a2566b627c58473bdaab.tar.gz servo-ef3903163da57ef31ee0a2566b627c58473bdaab.zip |
Auto merge of #16530 - metajack:kill-domrectlist, r=nox
Remove DOMRectList and use sequences instead.
DOMRectList was removed last back in 2015. See
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26200 for details.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they are covered by existing tests
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16530)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/element.rs')
-rw-r--r-- | components/script/dom/element.rs | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/components/script/dom/element.rs b/components/script/dom/element.rs index aafee25867c..7b56b6c6e81 100644 --- a/components/script/dom/element.rs +++ b/components/script/dom/element.rs @@ -34,7 +34,6 @@ use dom::create::create_element; use dom::document::{Document, LayoutDocumentHelpers}; use dom::documentfragment::DocumentFragment; use dom::domrect::DOMRect; -use dom::domrectlist::DOMRectList; use dom::domtokenlist::DOMTokenList; use dom::event::Event; use dom::eventtarget::EventTarget; @@ -1632,17 +1631,16 @@ impl ElementMethods for Element { } // https://drafts.csswg.org/cssom-view/#dom-element-getclientrects - fn GetClientRects(&self) -> Root<DOMRectList> { + fn GetClientRects(&self) -> Vec<Root<DOMRect>> { let win = window_from_node(self); let raw_rects = self.upcast::<Node>().content_boxes(); - let rects = raw_rects.iter().map(|rect| { + raw_rects.iter().map(|rect| { DOMRect::new(win.upcast(), rect.origin.x.to_f64_px(), rect.origin.y.to_f64_px(), rect.size.width.to_f64_px(), rect.size.height.to_f64_px()) - }); - DOMRectList::new(&win, rects) + }).collect() } // https://drafts.csswg.org/cssom-view/#dom-element-getboundingclientrect |