diff options
| author | Josh Matthews <josh@joshmatthews.net> | 2024-08-22 07:42:36 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-22 11:42:36 +0000 |
| commit | 60ef6bc46125d34e492a4294622e2791f3c619b5 (patch) | |
| tree | 8bc8a90f3a4647a7d6565065a8d73bd1b8f29d3d /components/script/dom/dompointreadonly.rs | |
| parent | 9a1051c9170abc8e40c43b2a6be712a3ff4b523f (diff) | |
| download | servo-60ef6bc46125d34e492a4294622e2791f3c619b5.tar.gz servo-60ef6bc46125d34e492a4294622e2791f3c619b5.zip | |
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Propagate CanGc from reflect_dom_object_with_proto.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Mark DOM constructors as GC operations.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/dompointreadonly.rs')
| -rw-r--r-- | components/script/dom/dompointreadonly.rs | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/components/script/dom/dompointreadonly.rs b/components/script/dom/dompointreadonly.rs index a782d6b5180..74bf1569405 100644 --- a/components/script/dom/dompointreadonly.rs +++ b/components/script/dom/dompointreadonly.rs @@ -13,6 +13,7 @@ use crate::dom::bindings::error::Fallible; use crate::dom::bindings::reflector::{reflect_dom_object_with_proto, Reflector}; use crate::dom::bindings::root::DomRoot; use crate::dom::globalscope::GlobalScope; +use crate::script_runtime::CanGc; // http://dev.w3.org/fxtf/geometry/Overview.html#dompointreadonly #[dom_struct] @@ -37,7 +38,7 @@ impl DOMPointReadOnly { } pub fn new(global: &GlobalScope, x: f64, y: f64, z: f64, w: f64) -> DomRoot<DOMPointReadOnly> { - Self::new_with_proto(global, None, x, y, z, w) + Self::new_with_proto(global, None, x, y, z, w, CanGc::note()) } fn new_with_proto( @@ -47,23 +48,28 @@ impl DOMPointReadOnly { y: f64, z: f64, w: f64, + can_gc: CanGc, ) -> DomRoot<DOMPointReadOnly> { reflect_dom_object_with_proto( Box::new(DOMPointReadOnly::new_inherited(x, y, z, w)), global, proto, + can_gc, ) } pub fn Constructor( global: &GlobalScope, proto: Option<HandleObject>, + can_gc: CanGc, x: f64, y: f64, z: f64, w: f64, ) -> Fallible<DomRoot<DOMPointReadOnly>> { - Ok(DOMPointReadOnly::new_with_proto(global, proto, x, y, z, w)) + Ok(DOMPointReadOnly::new_with_proto( + global, proto, x, y, z, w, can_gc, + )) } // https://drafts.fxtf.org/geometry/#dom-dompointreadonly-frompoint |