aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/domimplementation.rs
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2020-01-07 18:13:40 -0500
committerGitHub <noreply@github.com>2020-01-07 18:13:40 -0500
commite185423fc7b4e6b69fb27569c1c6ec8d5635d2eb (patch)
tree513c636acec0f4c221635b51894d7e73c68c2c9d /components/script/dom/domimplementation.rs
parent709e06928a3cd09426a54cab66aaa8557d739239 (diff)
parent67e9fc8c0ad5dd54a9947a3048f588a8ea55458e (diff)
downloadservo-e185423fc7b4e6b69fb27569c1c6ec8d5635d2eb.tar.gz
servo-e185423fc7b4e6b69fb27569c1c6ec8d5635d2eb.zip
Auto merge of #25310 - pshaughn:attr_node, r=Manishearth
Attr is a Node, with consequences for many Node methods <!-- Please describe your changes on the following line: --> Attr is now a Node, as current WHATWG specs require. I think I did some unidiomatic things to make compareDocumentPosition work and it could use a look by someone more familiar with how to write concise Rust code. I also think the new cases in compareDocumentPosition lack tests; it is possible to compare the position of two attributes, or of an attribute and an element, and I don't think any tests are exercising that functionality. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25124 <!-- Either: --> - [ ] There are tests for these changes (existing cases of Node methods are well-tested, and there is a WPT test specifically for whether Attr is Node, but I'm not sure about new Node method cases) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/domimplementation.rs')
0 files changed, 0 insertions, 0 deletions