diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-09-20 18:38:51 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-09-20 18:38:51 -0500 |
commit | dfb80f07539298d5972c8ca108dda5f83d8e009f (patch) | |
tree | 2f11927b574e29f1a96f62c4d40d63eaecd2be5c /components/script/dom/client.rs | |
parent | 6a791cd7f26b42a6688099bea203c21fb3c9cc12 (diff) | |
parent | eeed0b17eb21a5825ae4d454ee14fc824ce11eb4 (diff) | |
download | servo-dfb80f07539298d5972c8ca108dda5f83d8e009f.tar.gz servo-dfb80f07539298d5972c8ca108dda5f83d8e009f.zip |
Auto merge of #18583 - nnethercote:fix-TypedSize2D, r=mbrubeck
Fix MallocSizeOf for TypedSize2D.
TypedSize2D's MallocSizeOf impl has two problems.
- It measures `width` twice, and `height` not at all.
- It erroneously asserts that `width` and `height` are scalars. This
seems reasonable at first blush, but Stylo uses
`BorderRadius<LengthAndPercentage>` which contains a
`TypedSize2D<LengthAndPercentage, UnknownUnit>`, and
`LengthAndPercentage` is non-scalar.
This patch fixes both of these problems, and also removes a low-value
`use` statement.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1401692
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because tested on the Gecko side.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18583)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/client.rs')
0 files changed, 0 insertions, 0 deletions