diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-07-12 22:00:08 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-07-12 22:00:08 -0700 |
commit | 665559556f5aeac5820e17684b14311aa3767c0c (patch) | |
tree | 51990abfaeee9ba531e543322f9eccbef2663c7e /components/script/dom/browsingcontext.rs | |
parent | 496e45b190edc3b7f6ebb42e0a849a3d55a184d6 (diff) | |
parent | aea99e081bc7e138f05b967e3634b5dd01105106 (diff) | |
download | servo-665559556f5aeac5820e17684b14311aa3767c0c.tar.gz servo-665559556f5aeac5820e17684b14311aa3767c0c.zip |
Auto merge of #12406 - izgzhen:refactor-file, r=Manishearth
Refactor FileAPI implementation
Most are simple refactoring, cleanups and improvements, but still involving two slightly notable changes:
+ In `filemanager`, now we read the file content based on requested `RelativePos` by `seek` and `read_exact` (rather than `read_to_end` then do slicing). This strategy might be again adjusted in future performance tuning but certainly better than nothing.
+ Also, I cached more file meta-info in both sides and left a block of comment on `filemanager`'s file reading mentioning the snapshot-state problem (not solved now though).
r? @Manishearth
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12406)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/browsingcontext.rs')
0 files changed, 0 insertions, 0 deletions