diff options
| author | Emilio Cobos Álvarez <emilio@crisal.io> | 2017-09-17 07:43:05 +0200 |
|---|---|---|
| committer | Emilio Cobos Álvarez <emilio@crisal.io> | 2017-09-17 18:42:24 +0200 |
| commit | 5281fc1a440a6a179f7f8cb4788a9694904d0520 (patch) | |
| tree | 21c42095baca284bb48d318a8b25f99380957a29 /components/script/dom/bindings | |
| parent | b29e56eefcf0710bec318781de9bce5aabb5348a (diff) | |
| download | servo-5281fc1a440a6a179f7f8cb4788a9694904d0520.tar.gz servo-5281fc1a440a6a179f7f8cb4788a9694904d0520.zip | |
script: Add a comment about some conversion that looks fishy.
Diffstat (limited to 'components/script/dom/bindings')
| -rw-r--r-- | components/script/dom/bindings/conversions.rs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/components/script/dom/bindings/conversions.rs b/components/script/dom/bindings/conversions.rs index 9afae9f6804..6ae233aa034 100644 --- a/components/script/dom/bindings/conversions.rs +++ b/components/script/dom/bindings/conversions.rs @@ -84,13 +84,13 @@ impl<T: Float + FromJSValConvertible<Config=()>> FromJSValConvertible for Finite value: HandleValue, option: ()) -> Result<ConversionResult<Finite<T>>, ()> { - let result = match FromJSValConvertible::from_jsval(cx, value, option) { - Ok(ConversionResult::Success(v)) => v, - Ok(ConversionResult::Failure(error)) => { + let result = match FromJSValConvertible::from_jsval(cx, value, option)? { + ConversionResult::Success(v) => v, + ConversionResult::Failure(error) => { + // FIXME(emilio): Why throwing instead of propagating the error? throw_type_error(cx, &error); return Err(()); } - _ => return Err(()), }; match Finite::new(result) { Some(v) => Ok(ConversionResult::Success(v)), |