diff options
author | Simon Sapin <simon.sapin@exyr.org> | 2017-10-16 14:35:30 +0200 |
---|---|---|
committer | Simon Sapin <simon.sapin@exyr.org> | 2017-10-16 17:16:20 +0200 |
commit | aa15dc269f41503d81ad44cd7e85d69e6f4aeac7 (patch) | |
tree | 981d8d64c8de6ffd4c9e855553f34b6d09856d88 /components/script/dom/bindings/weakref.rs | |
parent | a5100e3c783f140c368da89e25e50581dce91bfd (diff) | |
download | servo-aa15dc269f41503d81ad44cd7e85d69e6f4aeac7.tar.gz servo-aa15dc269f41503d81ad44cd7e85d69e6f4aeac7.zip |
Remove use of unstable box syntax.
http://www.robohornet.org gives a score of 101.36 on master,
and 102.68 with this PR. The latter is slightly better,
but probably within noise level.
So it looks like this PR does not affect DOM performance.
This is expected since `Box::new` is defined as:
```rust
impl<T> Box<T> {
#[inline(always)]
pub fn new(x: T) -> Box<T> {
box x
}
}
```
With inlining, it should compile to the same as box syntax.
Diffstat (limited to 'components/script/dom/bindings/weakref.rs')
-rw-r--r-- | components/script/dom/bindings/weakref.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/components/script/dom/bindings/weakref.rs b/components/script/dom/bindings/weakref.rs index 885fa62cdc1..e3cff6175b5 100644 --- a/components/script/dom/bindings/weakref.rs +++ b/components/script/dom/bindings/weakref.rs @@ -56,10 +56,10 @@ pub trait WeakReferenceable: DomObject + Sized { .to_private() as *mut WeakBox<Self>; if ptr.is_null() { trace!("Creating new WeakBox holder for {:p}.", self); - ptr = Box::into_raw(box WeakBox { + ptr = Box::into_raw(Box::new(WeakBox { count: Cell::new(1), value: Cell::new(Some(NonZero::new_unchecked(self))), - }); + })); JS_SetReservedSlot(object, DOM_WEAK_SLOT, PrivateValue(ptr as *const c_void)); } let box_ = &*ptr; |