diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2015-10-28 17:24:36 +0530 |
---|---|---|
committer | bors-servo <lbergstrom+bors@mozilla.com> | 2015-10-28 17:24:36 +0530 |
commit | 3efa74997626afb3eda0f34842a4969da468dff0 (patch) | |
tree | b53950d7cd9c76a9877ced131f092b61f99f7a48 /components/script/dom/bindings/utils.rs | |
parent | 8cc6ce4b86d35625a90546f3d5829e3be4a33db9 (diff) | |
parent | c82b6ce8431e1379b7bd4689c2aadadbdc65c8b7 (diff) | |
download | servo-3efa74997626afb3eda0f34842a4969da468dff0.tar.gz servo-3efa74997626afb3eda0f34842a4969da468dff0.zip |
Auto merge of #8226 - froydnj:gc-zeal, r=Ms2ger
unblock using JS_GC_ZEAL
I think these patches move the `JS_SetReservedSlot` call to the right place for #6057. I'm not sure that the interface to `create_dom_global` is the best; passing a `JSVal` or a `*libc::c_void` seemed about equal, so I'd welcome feedback there.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8226)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/bindings/utils.rs')
-rw-r--r-- | components/script/dom/bindings/utils.rs | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/components/script/dom/bindings/utils.rs b/components/script/dom/bindings/utils.rs index 27fdb3efa9c..45a06674cfc 100644 --- a/components/script/dom/bindings/utils.rs +++ b/components/script/dom/bindings/utils.rs @@ -9,7 +9,7 @@ use dom::bindings::codegen::PrototypeList; use dom::bindings::codegen::PrototypeList::MAX_PROTO_CHAIN_LENGTH; use dom::bindings::conversions::native_from_handleobject; use dom::bindings::conversions::private_from_proto_check; -use dom::bindings::conversions::{is_dom_class, jsstring_to_str}; +use dom::bindings::conversions::{is_dom_class, jsstring_to_str, DOM_OBJECT_SLOT}; use dom::bindings::error::throw_type_error; use dom::bindings::error::{Error, ErrorResult, Fallible, throw_invalid_this}; use dom::bindings::global::GlobalRef; @@ -625,6 +625,7 @@ pub fn has_property_on_prototype(cx: *mut JSContext, proxy: HandleObject, /// Create a DOM global object with the given class. pub fn create_dom_global(cx: *mut JSContext, class: *const JSClass, + private: *const libc::c_void, trace: JSTraceOp) -> *mut JSObject { unsafe { @@ -640,6 +641,7 @@ pub fn create_dom_global(cx: *mut JSContext, class: *const JSClass, return ptr::null_mut(); } let _ac = JSAutoCompartment::new(cx, obj.ptr); + JS_SetReservedSlot(obj.ptr, DOM_OBJECT_SLOT, PrivateValue(private)); JS_InitStandardClasses(cx, obj.handle()); initialize_global(obj.ptr); JS_FireOnNewGlobalObject(cx, obj.handle()); |