diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2020-01-10 23:26:06 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-01-10 23:26:06 -0500 |
commit | 63cb13f5fa5f52d3574eb0da883f881b52e208ff (patch) | |
tree | 89846d1f271eaa97bda2e1921e944a98a5ecdf60 /components/script/dom/bindings/utils.rs | |
parent | c5069835d72bb7c14034c13674b6d1b500a95425 (diff) | |
parent | 87e86c81b98f7434711897b94606faba25b1dc5d (diff) | |
download | servo-63cb13f5fa5f52d3574eb0da883f881b52e208ff.tar.gz servo-63cb13f5fa5f52d3574eb0da883f881b52e208ff.zip |
Auto merge of #25405 - pshaughn:minmaxstep, r=jdm
make stepUp, stepDown, valueAsNumber, valueAsDate, and list work in HTMLInputElement
<!-- Please describe your changes on the following line: -->
Steppy operation of input elements now functions. A few related tests still fail because of incorrect test expectations. A couple range reftests fail on what might be correct expectations; solving that involves layout, not DOM.
Main changes here:
- str.rs now has its datetime format parsers public, with some changes to align their output with chrono::NaiveDateTime and fix a bug in milliseconds validation
- HTMLInputElement has new attributes, and code behind them for relevant concepts
- servoparser/mod.rs now has some extra code to ensure that input sanitization happens at the right moment during input element creation; the spec is non-specific about when this happens, but it has to happen somewhere and in #21952 @Eijebong had independently come to the same conclusion as me about the timing.
- Some tests are added where WPT wasn't already testing functionality I was adding; Firefox and Chrome pass them, Safari fails some in a reasonably expected way
- Lots of test metadata changed to passing
One test continues to fail because 0.1 * 6 != 0.6 and the spec is written in abstractions instead of actual floating-point numbers; other test failures are WPT bugs I've reported as such and will write fixes for soon if no one else does.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25390 and fix #25388 and fix #19773 (except validation doesn't exist) and fix #25386
<!-- Either: -->
- [X] There are tests for these changes OR
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/bindings/utils.rs')
0 files changed, 0 insertions, 0 deletions