diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-07-26 00:44:28 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-07-26 00:44:28 -0500 |
commit | a94b92f8c4f3e3edbc8db7c106fe2b6d3a5d82ae (patch) | |
tree | 679ec85563ddd03d2792c31d2b24babef5b60d56 /components/script/dom/bindings/interface.rs | |
parent | 4e18c230d031388570780ea0382eb5f7c6567a96 (diff) | |
parent | 2475dc1d21343e7cdda8b77be87be4484ee0f15a (diff) | |
download | servo-a94b92f8c4f3e3edbc8db7c106fe2b6d3a5d82ae.tar.gz servo-a94b92f8c4f3e3edbc8db7c106fe2b6d3a5d82ae.zip |
Auto merge of #11791 - craftytrickster:11712/pipeline-lookup, r=asajeffrey
Pipeline lookup in webdriver
Fixes #11712
<!-- Please describe your changes on the following line: -->
Removed a method that seemed to duplicate already existing functionality, and returned BrowsingContextErrors in the web_handler file where panics were previously occurring.
I am not sure if I like all the unwrapping that occurs in the script thread, but the current methods are not set up to return Option/Result.
Also, should line the method on line 37 `find_node_by_unique_id` of components/script/webdriver_handlers.rs return None if the context is not found like I have it currently? Or should it return a `Result<Option...>` instead?
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11712 .
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because I simply removed a method that duplicated already existing functionality. On the other part, I added better error sending instead of forcing a panic, which does not require testing to my knowledge.
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11791)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/bindings/interface.rs')
0 files changed, 0 insertions, 0 deletions