diff options
author | Josh Matthews <josh@joshmatthews.net> | 2020-06-04 12:46:25 -0400 |
---|---|---|
committer | Josh Matthews <josh@joshmatthews.net> | 2020-06-04 20:54:36 -0400 |
commit | 6dc4488bc7bee559021b8d0d780f0734d7cf5723 (patch) | |
tree | cb48197d8e7cadea634fa2a0cfc8265a86e79921 /components/script/dom/bindings/conversions.rs | |
parent | 9788c5c7f45d237fe15d7ce40285596d87034b48 (diff) | |
download | servo-6dc4488bc7bee559021b8d0d780f0734d7cf5723.tar.gz servo-6dc4488bc7bee559021b8d0d780f0734d7cf5723.zip |
Remove unnecessary generic from private_from_proto_check.
Diffstat (limited to 'components/script/dom/bindings/conversions.rs')
-rw-r--r-- | components/script/dom/bindings/conversions.rs | 28 |
1 files changed, 20 insertions, 8 deletions
diff --git a/components/script/dom/bindings/conversions.rs b/components/script/dom/bindings/conversions.rs index da4334207bf..97bd3338d8d 100644 --- a/components/script/dom/bindings/conversions.rs +++ b/components/script/dom/bindings/conversions.rs @@ -404,6 +404,11 @@ pub unsafe fn get_dom_class(obj: *mut JSObject) -> Result<&'static DOMClass, ()> Err(()) } +pub(crate) enum PrototypeCheck { + Derive(fn(&'static DOMClass) -> bool), + Depth { depth: usize, proto_id: u16 }, +} + /// Get a `*const libc::c_void` for the given DOM object, unwrapping any /// wrapper around it first, and checking if the object is of the correct type. /// @@ -411,14 +416,11 @@ pub unsafe fn get_dom_class(obj: *mut JSObject) -> Result<&'static DOMClass, ()> /// not an object for a DOM object of the given type (as defined by the /// proto_id and proto_depth). #[inline] -pub unsafe fn private_from_proto_check<F>( +pub(crate) unsafe fn private_from_proto_check( mut obj: *mut JSObject, cx: *mut JSContext, - proto_check: F, -) -> Result<*const libc::c_void, ()> -where - F: Fn(&'static DOMClass) -> bool, -{ + proto_check: PrototypeCheck, +) -> Result<*const libc::c_void, ()> { let dom_class = get_dom_class(obj).or_else(|_| { if IsWrapper(obj) { trace!("found wrapper"); @@ -437,7 +439,14 @@ where } })?; - if proto_check(dom_class) { + let prototype_matches = match proto_check { + PrototypeCheck::Derive(f) => (f)(dom_class), + PrototypeCheck::Depth { depth, proto_id } => { + dom_class.interface_chain[depth] as u16 == proto_id + }, + }; + + if prototype_matches { trace!("good prototype"); Ok(private_from_object(obj)) } else { @@ -471,7 +480,10 @@ pub fn native_from_object<T>(obj: *mut JSObject, cx: *mut JSContext) -> Result<* where T: DomObject + IDLInterface, { - unsafe { private_from_proto_check(obj, cx, T::derives).map(|ptr| ptr as *const T) } + unsafe { + private_from_proto_check(obj, cx, PrototypeCheck::Derive(T::derives)) + .map(|ptr| ptr as *const T) + } } /// Get a `*const T` for a DOM object accessible from a `JSObject`, where the DOM object |